Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline che-plugin-registry build fails to embed all vsix files for plugins with depedencies #19746

Closed
5 of 23 tasks
ericwill opened this issue May 4, 2021 · 1 comment
Closed
5 of 23 tasks
Assignees
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@ericwill
Copy link
Contributor

ericwill commented May 4, 2021

Describe the bug

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Build the che-plugin-registry with the offline parameter: build.sh --offline.
  2. When the build finishes, enter the container to inspect the generated meta.yaml files.
  3. Find the meta.yaml for a plugin that has dependencies, i.e. the ``metaYaml -> extraDependencies` field
  4. Look at the extensions field and observe that the 2nd and onward extensions are not relative: links but are regular HTTP URLs.

For example, the node-debug2 plugin meta.yaml:

apiVersion: v2
publisher: ms-vscode
name: node-debug2
version: latest
type: VS Code extension
displayName: Node Debug
title: Node Debug
description: Node.js debugging support
icon: /v3/images/ms-vscode-node-debug2-icon.png
category: Debuggers
repository: 'https://github.com/Microsoft/vscode-node-debug2.git'
firstPublicationDate: '2020-10-07'
latestUpdateDate: '2021-05-04'
spec:
  containers:
    - image: 'quay.io/eclipse/che-plugin-sidecar@sha256:4bce2e39fee6b9e4a8b4e8681380ce2462674597a48b81c131cbbf055dd5d0c3'
      name: vscode-node-debug
      memoryLimit: 512Mi
      cpuRequest: 30m
      cpuLimit: 500m
      env:
        - name: CHE_THEIA_SIDECAR_PREFERENCES
          value: '{"debug.node.useV3":false}'
  extensions:
    - 'relative:extension/resources/open-vsx_org/api/ms-vscode/node-debug2/1_42_5/file/ms-vscode.node-debug2-1.42.5.vsix'
    - 'https://open-vsx.org/api/ms-vscode/node-debug/1.44.8/file/ms-vscode.node-debug-1.44.8.vsix'

Expected behavior

All links in the extensions field should be relative: when building with the offline parameter.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: N/A

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • N/A

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context

@ericwill ericwill added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/plugin-registry labels May 4, 2021
@benoitf benoitf self-assigned this May 4, 2021
@ericwill ericwill changed the title Offline che-plugin-registry build fails to embed vsix files for plugins with depedencies Offline che-plugin-registry build fails to embed all vsix files for plugins with depedencies May 4, 2021
@ericwill
Copy link
Contributor Author

Fixed by eclipse-che/che-plugin-registry#953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

2 participants