-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to Che-Theia preferences are persisted and loaded at every workspace start using a ConfigMap #20622
Comments
@svor @vinokurig: since che-server doesn't manage users preferences anymore, we should use a mechanism similar to what we do for secrets but using a configmap to store the preferences of a user. |
Related to eclipse-che/che-server#117 |
blocked by #20749 |
Hi, a question to the assignee of this issue: Will the outcome require any changes to the relevant content of the Installation Guide or Administration Guide or End-user Guide? Yes/No? |
I don't think so, this is just a technical debt. |
moving issue to 7.42 milestone as this issue is part of the endgame |
This doesn't work for me. I am trying on next channel but preferences are not persisted. I have started a workspace, I set git user name and email, I have changed the theme but when the workspace is restarted these preferences are lost. Reopening. |
for some reason screencast-nimbus-capture-2022.01.24-13_35_24.mp4 |
@svor I forgot to mention that I had setup gitcredentials secret with my github token in my namespace. That may have an effect on git user name and email. To clarify I have done the following on an openshift cluster:
|
some investigation around screencast-git.luolix.top-2022.01.24-14_14_01.mp4 |
@l0rd @vinokurig I've created another issue about restoring Theme Color preferences #21065 |
The problem with git config may be related to the new way of the DevWorkspace to set that: devfile/devworkspace-operator#708 (comment)? |
Yes, the problem is that |
@l0rd Could you please elaborate on how did you set git user name and email? |
I create a secret: USERNAME=<my-gh-username>
PERSONAL_ACCESS_TOKEN=<my-access-token>
GIT_WEBSITE="github.com"
CREDENTIALS=$(echo -n "https://${USERNAME}:${PERSONAL_ACCESS_TOKEN}@${GIT_WEBSITE}" | base64) #<== this command works on macOS only
kubectl apply -f - <<EOF
kind: Secret
apiVersion: v1
metadata:
name: git-credentials-secret
annotations:
controller.devfile.io/mount-path: /etc/git-credentials/
labels:
controller.devfile.io/watch-secret: 'true'
controller.devfile.io/git-credential: 'true'
type: Opaque
data:
credentials: ${CREDENTIALS}
EOF And then I updated the settings.json file (from Che-Theia preferences widget) with git name and email. |
I tried to create the secret by oAuth flow but this is brocken: #21077 |
So I managed to add a github token secret to the user namespace, and the |
The |
@l0rd do you still have this problem? |
Let me start a cluster to check that |
I was not able to start workspace (#21089). I will try again on Monday. |
@svor @vinokurig unfortunately I still have problems although one thing is working:
|
@l0rd Thanks for testing it. It seems that the problem is not related to the Preferences persisting. The information about username/email in the status bar is taken form the .gitconfig which doesn't exist in the container. The problem with .gitconfig is related to devfile/devworkspace-operator#694, I'm going to close current issue, please reopen it if you don't think so |
@svor @vinokurig I have created this separate issue: #21115 |
sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-2714 |
Is your enhancement related to a problem? Please describe
Che-Theia preferences are not persisted anymore. When I refresh the browser, when I restart a workapce ore when I create a new workspace, the preferences are reset.
Describe the solution you'd like
Persist preferences after refresh/restart and across all user workspaces.
Release Notes Text
When Che-Theia user preferences (including plugins preferences) are changed, they are persisted in a Kubernetes ConfigMap. When a workspace is restarted or when a new workspace is created the existing user preferences will be loaded. There is still a bug that prevents color theme preferences to be persisted. This is something that already worked whith DevWorkspace disabled.
The text was updated successfully, but these errors were encountered: