Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che-Theia Plugins view support for DevWorkspace based workspaces #20638

Closed
Tracked by #20830
vitaliy-guliy opened this issue Oct 13, 2021 · 7 comments
Closed
Tracked by #20830

Che-Theia Plugins view support for DevWorkspace based workspaces #20638

vitaliy-guliy opened this issue Oct 13, 2021 · 7 comments
Assignees
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Oct 13, 2021

Is your task related to a problem? Please describe

The existing functionality that installing a plugin adds a component to the devfile

components:
  - type: chePlugin
    id: che-incubator/typescript/latest
    ...

It works only for devfile V1 workspaces, but does not work for Devfile V2 as it's completely different.

To add vscode extension to devfile V2 workspace it needs to add the extension ID to .vscode/extensions.json as in the example
https://github.com/che-samples/java-spring-petclinic/blob/devfilev2/.vscode/extensions.json

It's not a big deal for plugins, that are running in the same container withing Che-Theia. It's possible to take an extension ID or even URI (if it works) and add it to extensions.json.

But it needs to be discusses as well what shall we do with plugins, that are running inside separate container.

Describe the solution you'd like

Find a way to install a plugin from che-pluin-registry to devfile V2 workspace.

Release Notes Text

Che-Theia now supports plugins management from the built-in Plugin View for DevWorkspace based workspaces as well.

@vitaliy-guliy vitaliy-guliy added kind/task Internal things, technical debt, and to-do tasks to be performed. team/plugins severity/P1 Has a major impact to usage or development of the system. area/plugins labels Oct 13, 2021
@benoitf
Copy link
Contributor

benoitf commented Oct 25, 2021

@vitaliy-guliy it's working as well for plug-ins with sidecars if you add their ids in .vscode/extensions.json (or in .che/che-theia-plugins.yaml)

@max-cx
Copy link

max-cx commented Nov 15, 2021

Hi, a question to the assignee of this issue:

Will the outcome require any changes to the relevant content of the Installation Guide or Administration Guide or End-user Guide?

Yes/No?

@vitaliy-guliy
Copy link
Contributor Author

@max-cx I think we don't need to change any documentation

@vitaliy-guliy
Copy link
Contributor Author

vitaliy-guliy commented Dec 13, 2021

To have the perfect UX flow we need to have

@benoitf
Copy link
Contributor

benoitf commented Dec 21, 2021

moving issue to 7.42 milestone as this issue is part of the endgame

@svor svor mentioned this issue Jan 11, 2022
17 tasks
@svor svor modified the milestones: 7.42, 7.43 Jan 12, 2022
@svor svor mentioned this issue Jan 31, 2022
18 tasks
@svor svor modified the milestones: 7.43, 7.44 Feb 1, 2022
@vitaliy-guliy
Copy link
Contributor Author

@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Feb 10, 2022
@l0rd l0rd changed the title Allow to install plugins to Devfile V2 workspaces by using Che-Theia Plugins view Che-Theia Plugins view support for DevWorkspace based workspaces Feb 10, 2022
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-2748

@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

6 participants