Files in .vscode and .che folders of a git repository are ignored at workspace creation

[svor]

Describe the bug

All defined plugins from the extensions.json are not installed If create a workspace by the factory and che-theia editor.
Also I see that the tools component doesn't contain environment variables that should be injected by the Dashboard:

        - name: PLUGIN_REMOTE_ENDPOINT_EXECUTABLE
          value: /remote-endpoint/plugin-remote-endpoint
        - name: THEIA_PLUGINS
          value: 'local-dir:///plugins/sidecars/tools'

It's also not possible to customize an editor by using .che/che-editor.yaml file:

Che version

next (development version)

Steps to reproduce

1. Create a workspace by this factory: https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?che-editor=eclipse/che-theia/next
2. Open tools container and check that /plugins folder doesn't exist
3. Go to the Dasboard and check env variables in the tools component

Expected behavior

/plugins folder should be existed and plugins from the .vscode/extensions.json should be installed

Runtime

OpenShift

Screenshots

Installation method

chectl/next

Environment

Linux

Release Notes Text

Files in .vscode and .che subfolders need to be processed during workspace creation as they can contain important workspace details (as the editor and the che-theia plugins to pre-install) but were ignored in recent versions due to a regression. This has been fixed in this release.

[svor]

cc @olexii4 @akurinnoy

[olexii4]

I think it happened after this PR into the repo https://github.com/eclipse-che/che-theia.
@vitaliy-guliy WDYT?

[vitaliy-guliy]

I think it happened after this PR into the repo https://github.com/eclipse-che/che-theia. @vitaliy-guliy WDYT?

Due to all the tests in devworkspace-handler are passed, I think the problem might be something else.
I will check it anyway, give me some time.

[vitaliy-guliy]

It looks like I found cause of the problem.
First, when create a workspace from provided samples on the dashboard, everything is working well.

When the user create a workspace from git repository, dashboard tries to fetch .vscode/extensions.json file to get the list of extensions for the following adding them to the devworkspace object.
But for some reasons, GET request on .vscode/extensions.json fails.

It becomes much clear when trying to open the URL in the new tab

I tried to get other files from git repository and was able to get file content when the file or directory name do not contain dot at the beginning.

There is a potential place in che-server to fix the bug
https://github.com/eclipse-che/che-server/blob/main/wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/scm/AuthorizingFileContentProvider.java#L149

[azatsarynnyy]

Might be a related issue #21639

[devstudio-release]

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3350

• fix: Allow to get files from git repository if file name starts with dot che-server#351
• fix: Allow to get files from git repository if file name starts with dot che-server#353