Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile could not be found in the branch which name contains '/' sign #21706

Closed
svor opened this issue Sep 16, 2022 · 3 comments · Fixed by eclipse-che/che-server#523
Closed
Assignees
Labels
area/factory/server Server side of factory implementation kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/next

Comments

@svor
Copy link
Contributor

svor commented Sep 16, 2022

Describe the bug

In some cases users could have devfile.yaml file in the branch that contains / sign.
The problem is that it is not possible to create a workspace via factory by using this devfile.yaml.

In the dashboard I see a message like: "Devfile could not be found in repo. Applying the default configuration"

Che version

next (development version)

Steps to reproduce

  1. Create a branch with / sign in your repository with devfile.yaml
  2. Try to create a workspace by factory using this branch

OR

try this factory: https://che-host/#/https://github.com/svor/quarkus-api-example/tree/new/branch
in the dogfooding instance it's https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#/https://github.com/svor/quarkus-api-example/tree/new/branch

Expected behavior

The workspace should be started from the existing devfile

Runtime

OpenShift

Screenshots

screenshot-devspaces apps sandbox-m2 ll9k p1 openshiftapps com-2022 09 16-10_28_19

Installation method

chectl/next

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@svor svor added kind/bug Outline of a bug - must adhere to the bug report template. area/factory/server Server side of factory implementation labels Sep 16, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 16, 2022
@svor svor mentioned this issue Sep 19, 2022
59 tasks
@dkwon17 dkwon17 added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 20, 2022
@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2023
@svor
Copy link
Contributor Author

svor commented Mar 20, 2023

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2023
@l0rd
Copy link
Contributor

l0rd commented Jun 5, 2023

There are a couple of workarounds for this issue. Although they are not ideal and we need to address this issue, I am adding the workarounds here for information:

First workaround

Change the repository configuration so that the branch with the slashes (/) in the name is default branch. Then start the workspace using the URL with no branch (For example https://<che-host>/#https://github.com/l0rd/inventory-quarkus).

Second workaround

Explicitly add the project in the devfile and use the raw devfile link to start the workspace.

This is the devfile in branch new/branch of the repo github.com/l0rd/quarkus:

...
projects:
  - name: inventory-quarkus
    git:
      remotes:
        origin: 'https://github.com/l0rd/inventory-quarkus'
      checkoutFrom:
        revision: new/branch
...

And it can be started using URL https://<che-host>/#https://raw.githubusercontent.com/l0rd/inventory-quarkus/new/branch/.devfile.yaml

@ibuziuk ibuziuk moved this to 🚧 In Progress in Eclipse Che Team A Backlog Jun 7, 2023
@vinokurig vinokurig moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team A Backlog Jun 13, 2023
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Jun 15, 2023
@ibuziuk ibuziuk moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/factory/server Server side of factory implementation kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants