Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git repositories with names containing underscores and other characters not compliant with RFC-1123 #21750

Closed
ibuziuk opened this issue Oct 7, 2022 · 0 comments · Fixed by eclipse-che/che-dashboard#660
Assignees
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Oct 7, 2022

Describe the bug

Workspace startup is failing for repos like https://github.com/kamlendu1982/tower_engin

Che version

7.54@latest

Steps to reproduce

  1. Create a workspace based on the https://github.com/kamlendu1982/tower_engin repo
    ERROR: Failed to create a new workspace from the devfile, reason: Failed to create a new workspace. Unable to create devworkspace: DevWorkspace.workspace.devfile.io "tower_engin" is invalid: metadata.name: Invalid value: "tower_engin": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

Expected behavior

dashboard sanitizes the dw name and workspace starts without problems

Runtime

OpenShift

Screenshots

image

Installation method

OperatorHub

Environment

Amazon

Eclipse Che Logs

Failed to create a new workspace from the devfile, reason: Failed to create a new workspace. Unable to create devworkspace: DevWorkspace.workspace.devfile.io "tower_engin" is invalid: metadata.name: Invalid value: "tower_engin": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

Additional context

Reproducible on the dogfooding

@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/dashboard sprint/next labels Oct 7, 2022
@ibuziuk ibuziuk mentioned this issue Oct 7, 2022
67 tasks
@akurinnoy akurinnoy self-assigned this Oct 26, 2022
@l0rd l0rd changed the title Fail to create a new workspace based on the non-RFC-1123 compliant repo names Support git repositories with names containing underscores and other characters not compliant with RFC-1123 Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants