Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting ImagePullPolicy in CheCluster #21960

Closed
amisevsk opened this issue Jan 26, 2023 · 2 comments
Closed

Support setting ImagePullPolicy in CheCluster #21960

amisevsk opened this issue Jan 26, 2023 · 2 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@amisevsk
Copy link
Contributor

Is your enhancement related to a problem? Please describe

The DevWorkspace Operator allows configuring the image pull policy used for workspace containers through the DevWorkspaceOperatorConfig CR:

config:
  workspace:
    imagePullPolicy: <Always|IfNotPresent>

However, the only way to configure this for a Che installation is to either

  • Edit the devworkspace-config DevWorkspaceOperatorConfig in the Che install namespace (used for all Che workspaces), or
  • Create/edit the default DevWorkspaceOperatorConfig used by DWO globally.

Describe the solution you'd like

Che should expose (or reuse?) a field in the CheCluster that allows setting the image pull policy for workspace containers. This field should be propagated to the Che-owned DWOC in its install namespace

Describe alternatives you've considered

Manually editing the DevWorkspaceOperatorConfig created by Che works as well, but is hard to discover as a feature.

Additional context

Related: https://issues.redhat.com/browse/CRW-3357

@amisevsk amisevsk added kind/enhancement A feature request - must adhere to the feature request template. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/install Issues related to installation, including offline/air gap and initial setup labels Jan 26, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 26, 2023
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 27, 2023
@tolusha tolusha removed the area/install Issues related to installation, including offline/air gap and initial setup label Feb 14, 2023
@che-bot
Copy link
Contributor

che-bot commented Aug 13, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2023
@amisevsk
Copy link
Contributor Author

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2023
@tolusha tolusha self-assigned this Aug 16, 2023
@tolusha tolusha moved this to 📅 Planned in Eclipse Che Team A Backlog Aug 16, 2023
@tolusha tolusha moved this from 📅 Planned to 🚧 In Progress in Eclipse Che Team A Backlog Aug 21, 2023
@tolusha tolusha added this to the 7.74 milestone Aug 23, 2023
@tolusha tolusha closed this as completed Aug 23, 2023
@tolusha tolusha moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team A Backlog Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants