Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultPlugins from CR are ignored and not applied anymore during workspace startup #22017

Closed
ibuziuk opened this issue Feb 22, 2023 · 3 comments · Fixed by eclipse-che/che-dashboard#1028
Closed

defaultPlugins from CR are ignored and not applied anymore during workspace startup #22017

ibuziuk opened this issue Feb 22, 2023 · 3 comments · Fixed by eclipse-che/che-dashboard#1028
Assignees
@dkwon17
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Feb 22, 2023

Describe the bug

Previously it was possible to reference default plugins as devfile.yaml for various editors from CR:

devEnvironments:
      defaultComponents:
        - container:
            image: 'quay.io/devfile/universal-developer-image:ubi8-38da5c2'
            sourceMapping: /projects
          name: universal-developer-image
      defaultNamespace:
        template: <username>-dev
      defaultPlugins:
        - editor: eclipse/che-theia/latest
          plugins:
            - >-
              https://example.com/devfile.yaml
        - editor: eclipse/che-theia/next
          plugins:
            - >-
              https://example.com/devfile.yaml
       - editor: che-incubator/che-code/insiders
         plugins:
            - >-
              https://example.com/devfile.yaml

Che version

7.58

Steps to reproduce

  1. update CR accordingly based on description
  2. start a workspace and check if the default plugin is applied
  3. ERROR: plugins specified in CR are ignored

Expected behavior

plugins are added to the resulting DevWorkspace

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Amazon

Eclipse Che Logs

No response

Additional context

No response
@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. area/dashboard sprint/next severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che labels Feb 22, 2023
@dkwon17 dkwon17 self-assigned this May 4, 2023
This was referenced May 11, 2023
Closed
Merged
@dkwon17 dkwon17 moved this to Unplanned Tasks (In Progress) in Eclipse Che Team A Backlog May 16, 2023
@nickboldt nickboldt changed the title defaultPlugins from CR are ignored and not applied anymore during workspace startup [unplanned] defaultPlugins from CR are ignored and not applied anymore during workspace startup May 16, 2023
@ibuziuk ibuziuk moved this from Unplanned Tasks (In Progress) to Ready for Review in Eclipse Che Team A Backlog May 17, 2023
@ibuziuk
Copy link
Member Author

ibuziuk commented May 24, 2023

PR has been merged. Closing

@l0rd l0rd changed the title [unplanned] defaultPlugins from CR are ignored and not applied anymore during workspace startup defaultPlugins from CR are ignored and not applied anymore during workspace startup May 25, 2023
@ibuziuk ibuziuk moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog May 25, 2023
@ibuziuk ibuziuk closed this as completed May 25, 2023
@dkwon17 dkwon17 reopened this Dec 11, 2023
@dkwon17
Copy link
Contributor

dkwon17 commented Dec 11, 2023

This issue unfortunately has returned in the latest version of Che

@dkwon17 dkwon17 moved this from ✅ Done to 📋 Backlog in Eclipse Che Team A Backlog Dec 19, 2023
@svor svor moved this from 📋 Backlog to 📅 Planned in Eclipse Che Team A Backlog Dec 20, 2023
@dkwon17 dkwon17 mentioned this issue Dec 24, 2023
Merged
@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 2, 2024

I believe we need to make this issue a blocker for 3.11 since it breaks amplitude cc: @dmytro-ndp @mbenitez1607

@ibuziuk ibuziuk added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. and removed sprint/next labels Jan 8, 2024
@dkwon17 dkwon17 moved this from 📅 Planned to ✅ Done in Eclipse Che Team A Backlog Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkwon17 dkwon17

Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set che-editor annotation to devworkspace when using default editor eclipse-che/che-dashboard
2 participants
@ibuziuk @dkwon17