Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a new workspace from a RAW devfile URL doesn't support URL parameter for the devfile file name #22368

Closed
vinokurig opened this issue Jul 17, 2023 · 4 comments · Fixed by eclipse-che/che-server#548
Assignees
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@vinokurig
Copy link
Contributor

Describe the bug

We can start a new workspace from a RAW devfile URL. In case if the devfile file name differs from the conventional (devfile.yaml or .devfile.yaml) We have URL parameter for the devfile file name to be able to specify the devfile filename. Currently workspace fails to start from the Raw devfile URL with unconventional yaml name, either with the ?df=<filename>.yaml parameter.

Che version

7.71@latest

Steps to reproduce

  1. Create a GitHub gist named test.devfile with a simple devfile content. Copy the Raw URL of the gist.
  2. Start a workspace with the RAW devfile URL

See: workspace fails to start.

Expected behavior

Workspace starts successfully

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/latest

Environment

macOS

Eclipse Che Logs

No response

Additional context

No response

@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. area/che-server team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che labels Jul 17, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 17, 2023
@ibuziuk
Copy link
Member

ibuziuk commented Jul 17, 2023

IMO, ?df=<filename>.yaml parameter does not make sense for raw URLs. Wondering what break it in 3.7 if in 3.6 looks like any filename for raw URLs worked

@vinokurig
Copy link
Contributor Author

I assume this worked before the eclipse-che/che-server#519 PR. And before the PR it worked only for defiles by the GitHub RAW file content.

@vinokurig
Copy link
Contributor Author

@ibuziuk @l0rd

IMO, ?df=.yaml parameter does not make sense for raw URLs.

Do you think we should ignore the yaml file name for the RAW devfile URL approach?

@l0rd
Copy link
Contributor

l0rd commented Jul 17, 2023

@vinokurig if the user provides a link to the raw devfile then the name of the file is included in the link. We should ignore the df URL parameter.

@l0rd l0rd added status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 17, 2023
eformat added a commit to eformat/data-mesh-pattern that referenced this issue Aug 11, 2023
eformat added a commit to eformat/data-mesh-pattern that referenced this issue Aug 11, 2023
eformat added a commit to opendatahub-io-contrib/data-mesh-pattern that referenced this issue Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants