-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As an Admin I want to easily update 'Getting Started' / 'Select a Sample' view and point it to repositories we use inside our organization #22429
Comments
Should be the same structure like this? |
we can use a different or similar structure to devfile.io - whatever would be easier to support/maintain. Also, maybe this cm should be managed by the operator |
What does it mean? My suggestion: {
"displayName": "Eclipse Che Dashboard",
"description": "Specifies development environment needed to develop the Eclipse Che Dashboard.",
"tags": ["Eclipse Che", "Dashboard"],
"url": "https://github.com/che-incubator/quarkus-api-example/",
"icon": {
"base64data": <base64-encoded-data>,
"mediatype": "image/png"
}
} |
format lgtm, I do not know if it makes sense to have the cm be managed by the operator e.g. |
The ConfigMap must have some distinguish labels. apiVersion: v1
kind: ConfigMap
metadata:
name: getting-started
labels:
app.kubernetes.io/part-of: che.eclipse.org
app.kubernetes.io/component: devfile-metadata
data:
getting-started-samples: |-
[
{
"displayName": "Eclipse Che Dashboard",
"description": "Specifies development environment needed to develop the Eclipse Che Dashboard.",
"tags": ["Eclipse Che", "Dashboard"],
"url": "https://github.com/che-incubator/quarkus-api-example/",
"icon": {
"base64data": <base64-encoded-data>,
"mediatype": "image/png"
}
}
] |
LGTM, the only thing is |
Sounds better for me |
Proposal looks good to me 👍 |
@tolusha just want to double-check if any backports are needed for 7.74.x ? We really want to have this feature in 3.9 ;-) |
We have to backport the doc PR eclipse-che/che-docs#2646 |
Is your task related to a problem? Please describe
Motivation
Currently, it is very hard to add custom samples and update devfile registry - https://github.com/ibuziuk/che-devfile-registry
There is a plan to switch to devfile.io and a dedicated devfile registry operator to decouple samples from Dev Spaces as part of - #20251
Whereas this is an ultimate goal and would allow removing devfile-registry operand from the operator, there could be challenges for customers to use this approach
Describe the solution you'd like
As an Admin I want to update 'Getting Started' / 'Select a Sample' view and point it to repositories we use inside our organization. Basically, this could boil down to creating the cm with the list of repositories that would be read by the dashboard and displayed accordingly
The pros of this approach:
Describe alternatives you've considered
No response
Additional context
description
is optionaltag
is optionalicon
is optional, if not set on UD we display the default image:The text was updated successfully, but these errors were encountered: