Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new workspace creation URL parameter named editor-image #22733

Closed
l0rd opened this issue Dec 13, 2023 · 1 comment · Fixed by eclipse-che/che-dashboard#1037 or eclipse-che/che-dashboard#1053
Assignees
Labels
area/dashboard area/factory/dashboard Issues related to factories frontend (che user dashboard side) kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Dec 13, 2023

Is your enhancement related to a problem? Please describe

In some cases a user may want to re-use the existing che-code or che-idea definitions and replace the injectro container image only.

But for such use case we still require to copy the existing che-code or che-idea yaml definition, change the injector container image and reference the URL in the editor URL parameter. This is an unnecessary and error-prone work.

Describe the solution you'd like

Add a new URL parameter named editor-image with the following behavior:

  • The parameter is passed to the DevWorkspace generator that uses it to patch the <editor>-injector image.
  • This should work together with the editor URL parameter too. For example:
    • editor-image=quay.io/mloriedo/che-code:copilot-builtin ==> replace the default editor image
    • editor=che-incubator/che-idea/next&editor-image=quay.io/mloriedo/che-rider:2023:2 ==> use the che-incubator/che-idea/next editor but replace the of the injector image

This is a subtask of the epic #22729

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 13, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 13, 2023
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. area/dashboard area/factory/dashboard Issues related to factories frontend (che user dashboard side) and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 13, 2023
@olexii4 olexii4 self-assigned this Jan 3, 2024
@ibuziuk ibuziuk reopened this Feb 13, 2024
@ibuziuk
Copy link
Member

ibuziuk commented Feb 13, 2024

Reopening due to missing documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/factory/dashboard Issues related to factories frontend (che user dashboard side) kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
4 participants