Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Che repository to simplify location of agent storage #3437

Closed
TylerJewell opened this issue Dec 19, 2016 · 8 comments
Closed

Reorganize Che repository to simplify location of agent storage #3437

TylerJewell opened this issue Dec 19, 2016 · 8 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current status/in-progress This issue has been taken by an engineer and is under active development. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.

Comments

@TylerJewell
Copy link

We have started to add in various agents into Che. The code and packaging for these agents are located in different locations in the repository today. We should centralize all of the agent code into a single location.

  1. We would have a /agents folder in the root of the repository.
  2. exec-agent should be moved to /agents/exec.
  3. We should investigate and explore whether ws-agent, ssh agent, sync agent, and LSP agents can also be moved to a subfolder of /agents.
@TylerJewell TylerJewell added team/platform kind/task Internal things, technical debt, and to-do tasks to be performed. labels Dec 19, 2016
@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. and removed kind/task Internal things, technical debt, and to-do tasks to be performed. labels Dec 19, 2016
@skabashnyuk
Copy link
Contributor

skabashnyuk commented Dec 20, 2016

Our proposal is something like this

/agents
/agents/ws
/agents/exec
/agents/ssh
/plugins/plugin-1/server
/plugins/plugin-1/client
/plugins/plugin-1/shared
/plugins/plugin-1/agent

LSP is looks more like part of some language plugin

@skabashnyuk skabashnyuk added the status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach label Dec 20, 2016
@TylerJewell
Copy link
Author

Can you talk a bit more on lsp. When I look at the files it seems that it is both a plugin and an agent. And ultimately each ls is packaged using shared plugin but dedicated zip for the agent itself. So shouldn't we have both?

@TylerJewell
Copy link
Author

Also, @skabashnyuk - as part of this issue, I think we should move wsmaster to server. I think that will be clearer for people.

Also, after thinking about it, agree with your proposal on plugins. You are correct in that there are agents that are part of a plugin and agents that are just more cross-cutting.

I would like this to be in the next sprint - do you have an issue with that?

@skabashnyuk
Copy link
Contributor

We would like to stay with wsmaster name and narrow the scope of this task to simplify location of agent storage

@TylerJewell
Copy link
Author

Ok for this issue. But at least create another issue for the renaming of wsmaster to server as I think that is simpler name.

@skabashnyuk skabashnyuk added sprint/current status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. status/in-progress This issue has been taken by an engineer and is under active development. and removed status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Jan 6, 2017
@skabashnyuk
Copy link
Contributor

Continue refactoring we be done in #3720

@TylerJewell
Copy link
Author

@skabashnyuk - should we reopen this? I ask because the folder that was created did not have the right names. It was exec-agent instead of /agents/exec, for example.

@skabashnyuk
Copy link
Contributor

We have pr for rename #3775 it will be merged in 5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current status/in-progress This issue has been taken by an engineer and is under active development. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Development

No branches or pull requests

2 participants