CHE-1002 Add target UX improvements #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // There is a little bug in machine service on the server side. | ||
| // The machine info is updated with a little delay after running a machine. | ||
| // Using timer must fix the problem. | ||
| new Timer() { |
There was a problem hiding this comment.
Not clear about timer, how it solve problem? Why you set 500 not 600? Can accept it as urgent fix but must be fixed ASAP. Other ok for me
There was a problem hiding this comment.
If you say that there is a bug in machine API than create an issue and assign it to me, please.
There was a problem hiding this comment.
I'm not sure where is a problem. But when I receive a RUNNING state via websocket I ask the machine service about the machine and get CREATING state. Only waiting for a while gives the result.
There was a problem hiding this comment.
Sure it's a temporary desigion and has to be fixed ASAP.
|
+1 |
Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ Signed-off-by: Vitaliy Guliy vguliy@codenvy.com