CHE-998. Add 'Reimport' action for maven project #1277
Conversation
|
Great! But imo, ''New" menu item should be the first. Reimport is more rare case then add file or package. |
|
@mmorhun Done! |
|
Build # 603 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/603/ to view the results. |
| @@ -105,8 +106,10 @@ private void registerDefaultActionGroups() { | |||
| DefaultActionGroup mainContextMenuGroup = new DefaultActionGroup(IdeActions.GROUP_MAIN_CONTEXT_MENU, false, this); | |||
| registerAction(IdeActions.GROUP_MAIN_CONTEXT_MENU, mainContextMenuGroup); | |||
|
|
|||
| DefaultActionGroup buildContextMenuGroup = new DefaultActionGroup(IdeActions.GROUP_BUILD_CONTEXT_MENU, false, this); | |||
| DefaultActionGroup buildContextMenuGroup = new DefaultActionGroup("Maven", true, this); | |||
There was a problem hiding this comment.
Maven shouldn't be a constant ?
There was a problem hiding this comment.
@benoitf We have the same behavior here: https://github.com/eclipse/che/blob/19162869b908fb61794518a3765a47a5380d7158/core/ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/actions/ActionManagerImpl.java#L77-L101
I think we should have the consistent behavior.
So should we use constants in all places in this class?
@vparfonov WDYT?
There was a problem hiding this comment.
I think that constant for group's name isn't necessary. Because it used in one place only.
|
OK, alignements to be fixed in separate issue |
|
@vparfonov I've updated pull request, please review. |
| assistantGroup.add(getEffectivePomAction, Constraints.LAST); | ||
|
|
||
| // create maven context menu | ||
| DefaultActionGroup mavenContextMenuGroup = new DefaultActionGroup("Maven", true, actionManager); | ||
| actionManager.registerAction("mavenContextMenu", mavenContextMenuGroup); |
There was a problem hiding this comment.
action should be a constant
|
ok |
Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
@vparfonov @evidolob @slemeur