CHE-398: Add ability to create local machine snapshots without registry #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| @VisibleForTesting |
There was a problem hiding this comment.
why VisibleForTesting and not only protected access instead of package access ?
also there is no test calling this method so I don't see why it should be "VisibleForTesting"
akorneta
force-pushed
the
CHE-398
branch
2 times, most recently
from
ff5effb
to
863538d
Compare
| @@ -150,3 +149,6 @@ workspace.runtime.auto_snapshot=false | |||
| # During the start of the workspace automatically restored it from a snapshot if the value is {true}, | |||
| # otherwise just creates the new workspace. | |||
| workspace.runtime.auto_restore=false | |||
| # Allows to use registry for workspace snapshots, you should set this property in {true}, | |||
| # otherwise workspace snapshots would be saved locally. | |||
| workspace.snapshot_use_registry=false | |||
akorneta
force-pushed
the
CHE-398
branch
3 times, most recently
from
5514a93
to
2cd75bc
Compare
| final String digest = saveInRegistry(owner, repository, tag); | ||
| return new DockerInstanceKey(repository, tag, registry, digest); | ||
| } else { | ||
| createImage(owner, repository, tag); |
There was a problem hiding this comment.
I think it is better to name that method in the same way as saveInRegistry - saveLocallly
akorneta
force-pushed
the
CHE-398
branch
2 times, most recently
from
4000ffd
to
48e798d
Compare
|
LGTM |
|
ok |
|
ок |
|
Build # 732 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/732/ to view the results. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@garagatyi, @skabashnyuk, @evoevodin