Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using unsupported project's properties #13998

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Avoid using unsupported project's properties #13998

merged 2 commits into from
Jul 25, 2019

Conversation

ashumilova
Copy link
Contributor

@ashumilova ashumilova commented Jul 24, 2019 •
edited
Loading

What does this PR do?

  • Avoid using unsupported "path" and "displayName" properties in projects
  • Cleanups the console output from error: "Property 'githubToken' does not exist on type 'Storage'."

What issues does this PR fix or reference?

#13991

@ashumilova
Avoid using unsupported path and displayName properties in projects
66efc19 
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
@ashumilova
Fix the errors in output console
48abfe3 
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
@ashumilova ashumilova added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 24, 2019
@ashumilova ashumilova added this to the 7.0.0 milestone Jul 24, 2019
@ashumilova ashumilova self-assigned this Jul 24, 2019
@ashumilova
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 24, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13998
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

nickboldt
nickboldt approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0, no opinion.

@ashumilova
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 25, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13998
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1947/) doesn't show any regression against this Pull Request.

@ashumilova ashumilova merged commit 1b4cc73 into master Jul 25, 2019
@ashumilova ashumilova deleted the che-13991 branch July 25, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@olexii4 olexii4 olexii4 approved these changes

@akurinnoy akurinnoy Awaiting requested review from akurinnoy

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@ashumilova ashumilova

Labels
status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ashumilova @che-bot @artaleks9 @nickboldt @olexii4