Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing 0 to Happy path tests screencast png's #14292

Merged
merged 12 commits into from
Aug 22, 2019

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Aug 20, 2019

What does this PR do?

It fixes screenshot files naming so that they been sorted normally by name:

00000001-Java LS initialization-(11:32:3:701).png
00000002-Java LS initialization-(11:32:6:143).png
00000003-Java LS initialization-(11:32:8:392).png
00000004-Java LS initialization-(11:32:10:640).png
00000005-Java LS initialization-(11:32:12:925).png
00000006-Java LS initialization-(11:32:15:171).png
00000007-Java LS initialization-(11:32:17:422).png
00000008-Java LS initialization-(11:32:19:691).png
00000009-Java LS initialization-(11:32:21:931).png
00000010-Java LS initialization-(11:32:24:176).png
00000011-Java LS initialization-(11:32:26:412).png
00000012-Java LS initialization-(11:32:29:805).png

PR is about adding trailing 0 to the file number to normalize sorting.

Before

How list of files looked previously https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/che-regular-tests/view/K8S/job/CHE-7-Happy-Path-Tests/1117/artifact/e2e/report/executionScreencast/4-Java%20LS%20initialization/:
Screenshot from 2019-08-20 15-52-52

After

Screenshot from 2019-08-20 16-16-08

As you can see, last screenshot file will be always last in the list, so that makes heading file starting from "10000" as redundant as well.

Also, it makes it simple to create animated gif file - by one command within the the directory with screenshots:

ffmpeg -framerate 2 -pattern_type glob -i '*.png' -final_delay 100 out.gif

Updated "After"

Screenshot from 2019-08-21 20-01-35

Related issue

#14300

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Aug 20, 2019
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp dmytro-ndp force-pushed the fix-happy-path-tests-screencast branch from db6cb7a to 8e8ef37 Compare August 20, 2019 13:07
@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14292

@dmytro-ndp dmytro-ndp marked this pull request as ready for review August 20, 2019 13:21
@eclipse-che eclipse-che deleted a comment from che-bot Aug 20, 2019
Copy link
Contributor

@Katka92 Katka92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change.

@Katka92
Copy link
Contributor

Katka92 commented Aug 20, 2019

Just for curiosity, is it planned to have that animated gif as a part of the report?

@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14292

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp dmytro-ndp force-pushed the fix-happy-path-tests-screencast branch from 54f3a57 to 7e29b56 Compare August 21, 2019 16:07
@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14292

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp dmytro-ndp force-pushed the fix-happy-path-tests-screencast branch from 25f98a3 to c1f818d Compare August 21, 2019 19:59
@eclipse-che eclipse-che deleted a comment from che-bot Aug 21, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Aug 21, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@eclipse-che eclipse-che deleted a comment from che-bot Aug 21, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Aug 21, 2019
@dmytro-ndp
Copy link
Contributor Author

@Katka92 :

Just for curiosity, is it planned to have that animated gif as a part of the report?

Now it's about having screencast.mp4 like this one.
Making animated gif takes too much time.

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14292

@dmytro-ndp
Copy link
Contributor Author

Another advantage of creation of screencast video is decreasing the time for archiving build artifacts, and amount of data to save artifacts/ For example, executionScreencast.zip of 108 MiB produces screencast.mp4 of 14.5 MiB

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14292

@dmytro-ndp dmytro-ndp merged commit 318d052 into master Aug 22, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 22, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 22, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp dmytro-ndp deleted the fix-happy-path-tests-screencast branch August 22, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants