Add trailing 0 to Happy path tests screencast png's #14292

dmytro-ndp · 2019-08-20T12:57:00Z

What does this PR do?

It fixes screenshot files naming so that they been sorted normally by name:

00000001-Java LS initialization-(11:32:3:701).png
00000002-Java LS initialization-(11:32:6:143).png
00000003-Java LS initialization-(11:32:8:392).png
00000004-Java LS initialization-(11:32:10:640).png
00000005-Java LS initialization-(11:32:12:925).png
00000006-Java LS initialization-(11:32:15:171).png
00000007-Java LS initialization-(11:32:17:422).png
00000008-Java LS initialization-(11:32:19:691).png
00000009-Java LS initialization-(11:32:21:931).png
00000010-Java LS initialization-(11:32:24:176).png
00000011-Java LS initialization-(11:32:26:412).png
00000012-Java LS initialization-(11:32:29:805).png

PR is about adding trailing 0 to the file number to normalize sorting.

Before

How list of files looked previously https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/che-regular-tests/view/K8S/job/CHE-7-Happy-Path-Tests/1117/artifact/e2e/report/executionScreencast/4-Java%20LS%20initialization/:

After

As you can see, last screenshot file will be always last in the list, so that makes heading file starting from "10000" as redundant as well.

Also, it makes it simple to create animated gif file - by one command within the the directory with screenshots:

ffmpeg -framerate 2 -pattern_type glob -i '*.png' -final_delay 100 out.gif

Updated "After"

Related issue

#14300

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-08-20T13:17:19Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14292

Katka92

I like this change.

Katka92 · 2019-08-20T13:44:13Z

Just for curiosity, is it planned to have that animated gif as a part of the report?

che-bot · 2019-08-20T13:46:04Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

e2e/driver/CheReporter.ts

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-08-21T14:05:02Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14292

che-bot · 2019-08-21T14:24:23Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14292
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-08-21T14:32:19Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14292
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-08-21T14:44:37Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14292
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-08-21T15:16:42Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14292
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-08-21T15:42:36Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-08-21T16:25:31Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14292

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-08-21T20:16:44Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14292
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-08-21T20:41:16Z

@Katka92 :

Just for curiosity, is it planned to have that animated gif as a part of the report?

Now it's about having screencast.mp4 like this one.
Making animated gif takes too much time.

che-bot · 2019-08-21T20:44:52Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14292

dmytro-ndp · 2019-08-21T21:00:27Z

Another advantage of creation of screencast video is decreasing the time for archiving build artifacts, and amount of data to save artifacts/ For example, executionScreencast.zip of 108 MiB produces screencast.mp4 of 14.5 MiB

che-bot · 2019-08-21T21:16:34Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp · 2019-08-22T12:36:59Z

crw-ci-test

che-bot · 2019-08-22T12:55:43Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14292
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-08-22T13:05:02Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14292
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-08-22T13:33:19Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14292
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-08-22T13:33:58Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-08-22T14:41:08Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14292

che-bot · 2019-08-22T15:00:36Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Aug 20, 2019

Add trailing 0 to Happy path tests screencast png's

8e8ef37

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp force-pushed the fix-happy-path-tests-screencast branch from db6cb7a to 8e8ef37 Compare August 20, 2019 13:07

dmytro-ndp marked this pull request as ready for review August 20, 2019 13:21

dmytro-ndp requested review from l0rd, musienko-maxim, nickboldt, Ohrimenko1988 and rhopp as code owners August 20, 2019 13:21

eclipse-che deleted a comment from che-bot Aug 20, 2019

Katka92 approved these changes Aug 20, 2019

View reviewed changes

Ohrimenko1988 reviewed Aug 21, 2019

View reviewed changes

e2e/driver/CheReporter.ts Show resolved Hide resolved

Ohrimenko1988 approved these changes Aug 21, 2019

View reviewed changes

Make E2E Happy path tests screencast at PR check build

2fe7c0f

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Add number at the start of screenshot file

7e29b56

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp force-pushed the fix-happy-path-tests-screencast branch from 54f3a57 to 7e29b56 Compare August 21, 2019 16:07

dmytro-ndp added 3 commits August 21, 2019 19:31

[DON'T MERGE] PROVOKE FAILURE

7533025

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Work around default window size 800x600

05d360c

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Get rid of first screenshot with lower resolution 800*600

c1f818d

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp force-pushed the fix-happy-path-tests-screencast branch from 25f98a3 to c1f818d Compare August 21, 2019 19:59

eclipse-che deleted a comment from che-bot Aug 21, 2019

Restore HappyPath.spec.ts test

fb087f5

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

eclipse-che deleted a comment from che-bot Aug 21, 2019

dmytro-ndp added 3 commits August 22, 2019 15:27

Work around abcense of test screenshots

1ec0945

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Download chectl from next channel

a64e04d

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

[DO NOT MERGE] fail test to verify changes

2f31a15

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Fix screencast creation command in Jenkinsfile

013ff78

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Restore HappyPath.spec.ts

17677ba

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

dmytro-ndp merged commit 318d052 into master Aug 22, 2019

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 22, 2019

che-bot added this to the 7.1.0 milestone Aug 22, 2019

dmytro-ndp deleted the fix-happy-path-tests-screencast branch August 22, 2019 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add trailing 0 to Happy path tests screencast png's #14292

Add trailing 0 to Happy path tests screencast png's #14292

dmytro-ndp commented Aug 20, 2019 •

edited

Loading

che-bot commented Aug 20, 2019

Katka92 left a comment

Katka92 commented Aug 20, 2019

che-bot commented Aug 20, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

dmytro-ndp commented Aug 21, 2019

che-bot commented Aug 21, 2019

dmytro-ndp commented Aug 21, 2019

che-bot commented Aug 21, 2019

dmytro-ndp commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

Add trailing 0 to Happy path tests screencast png's #14292

Add trailing 0 to Happy path tests screencast png's #14292

Conversation

dmytro-ndp commented Aug 20, 2019 • edited Loading

What does this PR do?

Before

After

Updated "After"

Related issue

che-bot commented Aug 20, 2019

Katka92 left a comment

Choose a reason for hiding this comment

Katka92 commented Aug 20, 2019

che-bot commented Aug 20, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

che-bot commented Aug 21, 2019

dmytro-ndp commented Aug 21, 2019

che-bot commented Aug 21, 2019

dmytro-ndp commented Aug 21, 2019

che-bot commented Aug 21, 2019

dmytro-ndp commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

che-bot commented Aug 22, 2019

dmytro-ndp commented Aug 20, 2019 •

edited

Loading