Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker group IDs for boot2docker and Docker for Mac Beta #1490

Merged
merged 1 commit into from
Jun 24, 2016

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Jun 13, 2016

This is related to #1482. When running Che server inside a container, adding user to the local docker group (gid=999) is not enough. User should be added to the Docker host group too.

And in Docker for Mac Beta VM docker gid is 50, in boot2docker 100.

It worked accidentally on boot2docker because container user group and Docker host docker group had the same gid. But it did not work on Docker for Mac Beta.

Signed-off-by: Mario Loriedo mario.loriedo@gmail.com

@codenvy-ci
Copy link

Can one of the admins verify this patch?

@TylerJewell
Copy link

lgtm

@l0rd - can you confirm you have a CLA on file with Eclipse foundation? I have to assume you do. But the GitHub / Eclipse integration regularly seems to report users as not having a valid CLA. We can ignore it if you do.

@benoitf
Copy link
Contributor

benoitf commented Jun 13, 2016

@l0rd
Copy link
Contributor Author

l0rd commented Jun 13, 2016

I'll do that as soon as eclipse servers get back online. I can't log in right now.

@l0rd
Copy link
Contributor Author

l0rd commented Jun 13, 2016

image
done 😃

@TylerJewell
Copy link

@eivantsov @riuvshin - please review.

@l0rd l0rd changed the title Add docker group group IDs for boot2docker and Docker for Mac Beta Add docker group IDs for boot2docker and Docker for Mac Beta Jun 13, 2016
@garagatyi
Copy link

Looks like #1576 has part of changes from this PR. Why do you need both?

@l0rd
Copy link
Contributor Author

l0rd commented Jun 24, 2016

That's a rebase issue. I've rebased that commit on top #1576 to generate
the Docker image. I'll fix that.

On Friday, 24 June 2016, Alexander Garagatyi notifications@github.com
wrote:

Looks like #1576 #1576 has part of
changes from this PR. Why do you need both?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1490 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAlC73jvGYDMaKS8juATMjjeTMzWATERks5qPAnvgaJpZM4I0WxS
.

Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
@l0rd
Copy link
Contributor Author

l0rd commented Jun 24, 2016

@garagatyi should be ok now

@garagatyi
Copy link

LGTM

@TylerJewell TylerJewell merged commit ca6b821 into eclipse-che:master Jun 24, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants