Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Language Server Protocol #2452

Merged
merged 191 commits into from
Sep 16, 2016
Merged

Support for Language Server Protocol #2452

merged 191 commits into from
Sep 16, 2016

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 15, 2016

What does this PR do?

Implemented features

Base issue: #1287

New behavior

Support Language Server protocol

Please review Che's Contributing Guide for best practices.

svenefftinge and others added 30 commits May 20, 2016 17:50
…age server protocol.

It is based on the java binding from https://github.com/TypeFox/ls-api.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
… and ‘textDocument/publishDiagnostics’

The ‘publishDiagnostics’ is a server-side notification, which are sent back to the client via WebSocket.
Initial prototype of language server protocol extension for Che
…he into language-server

# Conflicts:
#	plugins/pom.xml
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
[lsp] added setter methods to DTOs
…les and runs them, if they are of the form ‘fileextension-languageserver.jar’

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
…onfiguration for Orion editor.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
…ile types, mime types and highlighting config.
… kind, shows documentation from CompletionItem
@tolusha
Copy link
Contributor Author

tolusha commented Sep 15, 2016

@evidolob
@vparfonov

@tolusha tolusha added status/in-progress This issue has been taken by an engineer and is under active development. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Sep 15, 2016
@tolusha tolusha added this to the 5.0.0-M2 milestone Sep 15, 2016
@codenvy-ci
Copy link

import java.util.LinkedList;
import java.util.List;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc

@@ -159,6 +163,7 @@ private void startWsAgentComponents(final Iterator<Provider<WsAgentComponent>> c
component.start(new Callback<WsAgentComponent, Exception>() {
@Override
public void onSuccess(WsAgentComponent result) {
Log.error(component.getClass(), result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like debug output

import org.eclipse.che.ide.api.component.WsAgentComponent;
import org.eclipse.che.ide.statepersistance.AppStateManager;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evidolob javadoc

* @author Evgen Vidolob
*/
public class Throttler {
// private Promise activePromise;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evidolob check please this comment code

@@ -0,0 +1,81 @@
package org.eclipse.che.plugin.languageserver.ide.editor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license


appContext.getWorkspaceRoot().getFile(filePath).then(openNode(selectionRange));

// .then(new Operation<Optional<File>>() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment code

public class DtoConverter {

public static InitializeResultDTO asDto(InitializeResult initializeResult) {
// List<LanguageDescriptionDTO> languageDescriptionDTOs = initializeResult.getSupportedLanguages()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment code

synchronized (launcher) {
LanguageServer server = languageIdToServers.get(languageId);
if (server != null) {
// LanguageServerDescription initializeResult = serversToInitResult.get(server);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment code


@Singleton
@Path("languageserver")
public class LanguageRegistryService {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc

@@ -0,0 +1,143 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this is good location for those scripts ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary solution until conception of AgentRegistry is done.

@codenvy-ci
Copy link

Build # 406 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/406/ to view the results.

@vparfonov
Copy link
Contributor

ok

@TylerJewell
Copy link

@tolusha @evidolob - this is substantial. congrats.

@tolusha tolusha merged commit c48a69f into master Sep 16, 2016
@tolusha tolusha deleted the language-server branch September 16, 2016 09:46
@riuvshin riuvshin modified the milestones: 5.0.0-M3, 5.0.0-M2 Sep 20, 2016
@bmicklea bmicklea mentioned this pull request Sep 28, 2016
63 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 2, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.