CHE-2816. Correctly applying exclude filters at indexing files #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build # 760 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/760/ to view the results. |
skabashnyuk
requested changes
Oct 24, 2016
|
@skabashnyuk I've added some explanation to clarify how I'm going to fix it |
skabashnyuk
approved these changes
Oct 24, 2016
vparfonov
approved these changes
Oct 25, 2016
Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
RomanNikitenko
force-pushed
the
CHE-2816
branch
from
fe5583f
to
8f3b187
Compare
|
Build # 795 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/795/ to view the results. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…se-che#2857) Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Current behavior: we need to have exclude filters here https://github.com/eclipse/che/blob/master/wsagent/che-core-api-project/src/main/java/org/eclipse/che/api/vfs/search/impl/LuceneSearcher.java#L95
and we have some filters for files that should NOT be indexed. But org.eclipse.che.api.vfs.search.MediaTypeFilter includes in result files that SHOULD be indexed.
New behavior: the media type filter will include in result files with media type that should NOT be indexed.
What issues does this PR fix or reference?
#2816
Signed-off-by: Roman Nikitenko rnikitenko@codenvy.com