Get projects after workspace has been already initialized #2867
Conversation
This commit also includes API reorganization. Move client service implementations from the core-api to the core-app. Code cleanup. Removed dependency to the javax.inject from the core-api to avoid duplicate using @Inject annotation from the com.google.inject and javax.inject. (Client side uses only com.google.inject.Inject annotation) Created two components: WsAgentInitializer - which is responsible to initialize workspace component on the client side. Component consumes developer machine object at startup stage. WsAgentMessageBusProvider - which is responsible to initialize message bus after workspace has been initialized. API movements: OAuthServiceClient was moved from the org.eclipse.che.ide.api.auth to the org.eclipse.ide.api.oauth
|
Build # 768 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/768/ to view the results. |
| * @see DevMachine | ||
| * @since 5.0.0 | ||
| */ | ||
| public interface WsAgentInitializer { |
There was a problem hiding this comment.
As far as I understood this interface is used in IDE app only and not intended to be used by extensions.
So, if it isn't a part of IDE public API why do we need it in IDE API? May be it would be better to move it in IDE app module?
There was a problem hiding this comment.
Yes, you're right, I'll move it to the IDE app
| @@ -139,7 +150,7 @@ public WsAgentState getState() { | |||
| return state; | |||
| } | |||
|
|
|||
| /** Returns instance of {@link MachineMessageBus}. */ | |||
| /** {@inheritDoc} */ | |||
| public Promise<MessageBus> getMessageBus() { | |||
There was a problem hiding this comment.
@OverRide annotation is missed
| * @param devMachine | ||
| * development machine instance | ||
| */ | ||
| /** {@inheritDoc} */ | ||
| public void initialize(DevMachine devMachine) { |
There was a problem hiding this comment.
@OverRide annotation is missed
| @@ -29,6 +31,7 @@ | |||
| * | |||
| * @author Sergii Leschenko | |||
| */ | |||
| @Singleton | |||
There was a problem hiding this comment.
Why did you add this annotation?
It's already bound as singleton in CoreGinModule.
| * @param devMachine | ||
| * development machine instance | ||
| */ | ||
| /** {@inheritDoc} */ |
There was a problem hiding this comment.
What is the purpose of an empty javadoc which contains @inheritdoc tag only?
Javadoc tool and all popular IDEs override it automatically when generating documentation.
IMO we should add it only in case of 'real' overriding javadoc like here.
WDYT?
There was a problem hiding this comment.
It's just personal habbit. I'll remove it.
| /** | ||
| * @author Sergii Leschenko | ||
| */ | ||
| @Singleton |
There was a problem hiding this comment.
Why did you add this annotation?
It's already bound as singleton in CoreGinModule.
|
Build # 770 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/770/ to view the results. |
|
Build # 781 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/781/ to view the results. |
# Conflicts: # ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/project/ProjectServiceClientImpl.java # plugins/plugin-maven/che-plugin-maven-ide/src/main/java/org/eclipse/che/plugin/maven/client/comunnication/MavenMessagesHandler.java
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/910/ |
…e#2867) * Get projects after workspace has been already initialized This commit also includes API reorganization. Move client service implementations from the core-api to the core-app. Code cleanup. Removed dependency to the javax.inject from the core-api to avoid duplicate using @Inject annotation from the com.google.inject and javax.inject. (Client side uses only com.google.inject.Inject annotation) Created two components: WsAgentInitializer - which is responsible to initialize workspace component on the client side. Component consumes developer machine object at startup stage. WsAgentMessageBusProvider - which is responsible to initialize message bus after workspace has been initialized. API movements: OAuthServiceClient was moved from the org.eclipse.che.ide.api.auth to the org.eclipse.ide.api.oauth * Move WsAgentInitizalizer to the core-app * Add @OverRide annotation * Add @OverRide annotation * Remove @singleton annotation * Remove @singleton annotation * Revert javax.inject.Inject annotation * Update codebase due to changes in the master branch
This commit also includes API reorganization. Move client service implementations from the core-api to the core-app. Code cleanup. Removed dependency to the
javax.injectfrom the core-api to avoid duplicate using@Injectannotation from thecom.google.injectandjavax.inject. (Client side uses onlycom.google.inject.Injectannotation)Created two components:
WsAgentInitializer - which is responsible to initialize workspace component on the client side. Component consumes developer machine object at startup stage.
WsAgentMessageBusProvider - which is responsible to initialize message bus after workspace has been initialized.
API movements:
OAuthServiceClientwas moved from theorg.eclipse.che.ide.api.authto theorg.eclipse.ide.api.oauthRelated issue: #2629
@vparfonov @ashumilova @azatsarynnyy review it, please.