Unexpected loss of focus on the project #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashumilova
reviewed
Nov 25, 2016
| @@ -120,20 +106,6 @@ public void onWsAgentStarted(WsAgentStateEvent event) { | |||
| restoreTerminal(); | |||
|
|
|||
| machinePortProvider.get(); | |||
| /* Do not show terminal on factories by default */ | |||
There was a problem hiding this comment.
why we remove this check here?
There was a problem hiding this comment.
As terminal doesn't get focus at startup we can show terminal after consuming factory.
There was a problem hiding this comment.
let's leave part closed for factories
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1119/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1125/ |
ashumilova
approved these changes
Nov 28, 2016
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Add ability to set up manual focus to the terminal panel * Fix imports * Add ability to auto select first node when tree becomes visible and it has at least one node * Fixes * Fixes
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to setup focus on Project Explorer part when IDE has already initialized.
Also was removed auto setting up focus on the terminal. So the terminal now handles
onblurandonfocusevents to control own state.Related issue: #2795
@riuvshin @ashumilova @vparfonov review it, please.