#2866 fix importing maven project with relative path in modules #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Signed-off-by: Evgen Vidolob <evidolob@codenvy.com>
| /** | ||
| * Set of useful String methods | ||
| */ | ||
| public class StringUtils { |
There was a problem hiding this comment.
It looks like useful methods not for the plugin-maven only.
I think che-core-commons-lang would be better place for this class.
| /** | ||
| * Set of util methods for path strings. | ||
| */ | ||
| public class PathUtil { |
There was a problem hiding this comment.
I think that che-core-commons-lang is better place for this util class.
Especially since we already have a special package org.eclipse.che.commons.lang.os there for the platform-specific utils.
Signed-off-by: Evgen Vidolob <evidolob@codenvy.com>
vparfonov
approved these changes
Dec 22, 2016
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…dules (eclipse-che#3457) * eclipse-che#2866 handle relative path and including 'pom.xml' in modules declarations Signed-off-by: Evgen Vidolob <evidolob@codenvy.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
handle relative path and including 'pom.xml in modules declarations
What issues does this PR fix or reference?
#2866