Load instance runtime information on machine start #3561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Machine runtime information is lazy-loaded and loading happens when workspace runtime information is requested first time. So basically it is possible to meet the state when workspace machine will be RUNNING but
Instance.getRuntime
won't return anything because it's the first call to get workspace runtime and there is a problem like the following:The changes introduced in the pull request load machine runtime information on machine start, ones it's loaded machine data is in consistent state with its status, if loading fails machine start will be also considered as failed.
Along with that workspace start problems are logged as warnings, e.g. if docker file is broken.
Fixes codenvy-1320.