Json RPC client-side to server-side port #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2017
svor
reviewed
Jan 5, 2017
| this.jsonParser = jsonParser; | ||
|
|
||
| this.jsonElementList = dtoObjectList.stream().map(Object::toString).map(jsonParser::parse).collect(Collectors.toList()); | ||
| ; |
svor
reviewed
Jan 5, 2017
| *******************************************************************************/ | ||
| package org.eclipse.che.api.core.jsonrpc; | ||
|
|
||
|
|
svor
reviewed
Jan 5, 2017
| checkNotNull(message, "Message must not be null"); | ||
| checkArgument(!message.isEmpty(), "Message must not be empty"); | ||
|
|
||
|
|
svor
reviewed
Jan 5, 2017
| *******************************************************************************/ | ||
| package org.eclipse.che.api.core.jsonrpc; | ||
|
|
||
|
|
svor
reviewed
Jan 5, 2017
| checkNotNull(message, "Message must not be null"); | ||
| checkArgument(!message.isEmpty(), "Message must not be empty"); | ||
|
|
||
|
|
svor
reviewed
Jan 5, 2017
| JsonArray jsonArray = jsonParser.parse(message).getAsJsonArray(); | ||
| this.jsonElementList = new ArrayList<>(jsonArray.size()); | ||
| for (int i = 0; i < jsonArray.size(); i++) { | ||
| jsonElementList.add(i, jsonArray.get(i)); |
There was a problem hiding this comment.
I think you can use smth like jsonElementList.forEach(jsonArray::add)
svor
reviewed
Jan 5, 2017
| *******************************************************************************/ | ||
| package org.eclipse.che.api.core.jsonrpc; | ||
|
|
||
|
|
svor
reviewed
Jan 5, 2017
| checkNotNull(message, "Message must not be null"); | ||
| checkArgument(!message.isEmpty(), "Message must not be empty"); | ||
|
|
||
|
|
svor
reviewed
Jan 5, 2017
| checkNotNull(method, "Method name must not be null"); | ||
| checkArgument(!method.isEmpty(), "Method name must not be empty"); | ||
|
|
||
|
|
svor
reviewed
Jan 5, 2017
| } | ||
|
|
||
| if (id != null) { | ||
| response.addProperty( |
svor
reviewed
Jan 5, 2017
| *******************************************************************************/ | ||
| package org.eclipse.che.api.core.jsonrpc; | ||
|
|
||
|
|
svor
reviewed
Jan 5, 2017
| private final String method; | ||
| private final Class<P> pClass; | ||
|
|
||
|
|
|
Build # 1530 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1530/ to view the results. |
|
Build # 1541 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1541/ to view the results. |
dkuleshov
force-pushed
the
json-rpc-wsagent-port
branch
from
8fde381
to
cbe2594
Compare
|
Build # 1556 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1556/ to view the results. |
|
ci-build |
|
Build # 1562 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1562/ to view the results. |
vparfonov
approved these changes
Jan 12, 2017
gazarenkov
approved these changes
Jan 13, 2017
added 4 commits
February 9, 2017 12:21
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
dkuleshov
force-pushed
the
json-rpc-wsagent-port
branch
from
cbe2594
to
2577e43
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1919/ |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #3143 to server-side
Changelog
Replicates changes done under issue #1947 and contained within PR #3032 including websocket and json rpc services modification but excluding exec agent client adaptation itself.