Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved find and navigate to file capabilities in IDE #3806

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Jan 19, 2017

Improved Navigate to file popup:

  • window borders and buttons have been removed
  • added scroll bars to the popup with suggestions

navigatetofile

Changelog

Improve find and navigate to file capabilities in IDE

Release Note:

  • Added to release not in enhancements section

@TylerJewell
Copy link

Super cool. Thanks for making the title change requested.

Let's crosslink a matching docs issue and a release notes continent from PM into this PR.

@slemeur
Copy link
Contributor

slemeur commented Jan 19, 2017

@vitaliy-guliy : here are some feedbacks
e2477994-de51-11e6-8557-261780b54011

Then:

  • I'd like to know how this behave if you zoom in / use Che in a small window.
  • We are displaying the complete path to the file. What is the mecanism you are using when the path is very long and cannot be displayed entirely on the screen? Should we truncate the text in some ways or show only the parts of it ?

@slemeur
Copy link
Contributor

slemeur commented Jan 19, 2017

The description of the PR is not detailed enough.

You need to explain what are the changes that you did to this popup in order to improve it.

@slemeur slemeur self-requested a review January 19, 2017 13:04
@codenvy-ci
Copy link

Build # 1689 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1689/ to view the results.

@slemeur
Copy link
Contributor

slemeur commented Jan 19, 2017

@vitaliy-guliy I created the following doc issue: https://github.com/codenvy/che-docs/issues/74

@slemeur
Copy link
Contributor

slemeur commented Jan 19, 2017

@vitaliy-guliy : we need you to work on the doc issue first. We will then be able to quickly edit the release note here:
https://docs.google.com/document/d/1cEbq32s9J2ygEfGd4d1ImvT3c7YZqfAbRL0PMC8HE48/edit#

@vitaliy-guliy
Copy link
Contributor Author

I recorded a video of the behavior when resizing
https://youtu.be/y6W9QwGul1s

@vitaliy-guliy
Copy link
Contributor Author

According to @slemeur feedback

  • the rounded box on the popup is removed
  • added more space on the left and right of the proposals box

navigate to file feature

@vitaliy-guliy
Copy link
Contributor Author

For now we display the complete file path and truncate it when there is not enough space to display.
This is an easiest way to display it. Displaying the part of the path is more complex due to it's difficult to forecast how the browser will render the table with proposals.

@codenvy-ci
Copy link

Build # 1704 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1704/ to view the results.

Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
@codenvy-ci
Copy link

Build # 1755 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1755/ to view the results.

@slemeur slemeur changed the title CHE-2617 Improve Find capabilities in IDE Improved find and cavigate to file capabilities in IDE Jan 25, 2017
@slemeur slemeur changed the title Improved find and cavigate to file capabilities in IDE Improved find and navigate to file capabilities in IDE Jan 25, 2017
@slemeur slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 25, 2017
Copy link
Contributor

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to release note and updated title

@vitaliy-guliy vitaliy-guliy merged commit 360ced6 into master Jan 25, 2017
@vitaliy-guliy vitaliy-guliy deleted the CHE-2617-2 branch January 25, 2017 09:48
@riuvshin riuvshin added this to the 5.2.0 milestone Feb 1, 2017
@JamesDrummond JamesDrummond mentioned this pull request Feb 6, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants