Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple testing framework API from Java test specific frameworks #3999

Merged
merged 13 commits into from
Feb 3, 2017

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Feb 2, 2017

What does this PR do?

This PR is a proposal for decoupling testing framework core API from Java specific testing frameworks.

What issues does this PR fix or reference?

#3452

Previous behavior

In current state all of the testing frameworks that are Java specific are tightly coupled with the testing framework core API, which complicates "straight-forward" adding of new testing frameworks (i.e. PHPUnit).

New behavior

  • Testing core framework API was moved to Che Core API packages (I was using the debugger API analogy)
  • All code in testing framework core API that was tightly coupled to Java specific testing frameworks (i.e. JUnit, TestNG) was unbound and moved to related plug-ins

That's more or less the general description of the changes that I have made. I am eager to answer all of the possible questions related to the details.

Signed-off-by: Bartlomiej Laczkowski bartlomiej.l@zend.com

Changelog

Decoupling of testing framework core API from Java specific testing frameworks implementation.

Release Notes:

N/A refactoring of existing code.

Docs PR:

None : same behavior than before

Bartlomiej Laczkowski and others added 11 commits December 20, 2016 20:18
Signed-off-by: Bartlomiej Laczkowski <bartlomiej.l@zend.com>
Signed-Off-By: Bartlomiej Laczkowski <bartlomiej.l@zend.com>
Signed-off-by: Bartlomiej Laczkowski <bartlomiej.l@zend.com>
Signed-off-by: Bartlomiej Laczkowski <bartlomiej.l@zend.com>
Signed-off-by: Bartlomiej Laczkowski <bartlomiej.l@zend.com>
Signed-off-by: Bartlomiej Laczkowski <bartlomiej.l@zend.com>
Signed-off-by: Bartlomiej Laczkowski <bartlomiej.l@zend.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@vparfonov vparfonov added this to the 5.3.0 milestone Feb 2, 2017
@vparfonov vparfonov self-assigned this Feb 2, 2017
@vparfonov vparfonov changed the title Bartlomiej laczkowski unit testing Decouple testing framework API from Java test specific frameworks Feb 2, 2017
wsagent/pom.xml Outdated
@@ -35,6 +35,8 @@
<module>che-core-api-debug-shared</module>
<module>che-core-api-languageserver</module>
<module>che-core-api-languageserver-shared</module>
<module>che-core-api-testing</module>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format

Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@codenvy-ci
Copy link

@vparfonov vparfonov added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 2, 2017
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@codenvy-ci
Copy link

@vparfonov vparfonov merged commit 50f641d into master Feb 3, 2017
@vparfonov vparfonov deleted the bartlomiej-laczkowski-unit-testing branch February 3, 2017 10:12
@JamesDrummond JamesDrummond mentioned this pull request Feb 17, 2017
9 tasks
@JamesDrummond JamesDrummond added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Feb 17, 2017
@JamesDrummond JamesDrummond removed kind/enhancement A feature request - must adhere to the feature request template. sprint/next labels Feb 17, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
…lipse-che#3999)

* Decouple testing framework core from Java specific test frameworks.

Signed-off-by: Bartlomiej Laczkowski <bartlomiej.l@zend.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants