Trigger file saving operation on editor closing only when file has changes #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
added
kind/enhancement
vparfonov
approved these changes
Feb 9, 2017
|
Build # 1922 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1922/ to view the results. |
|
Build # 1959 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1959/ to view the results. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1965/ |
slemeur
changed the title
slemeur
added
kind/bug
voievodin
pushed a commit
that referenced
this pull request
Feb 28, 2017
* Disable file saving on editor closing * Add test use case
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Disable file saving on editor closing * Add test use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes proposal disable automatically file saving on editor closing.
The previous version doesn't care about whether file changed or not and automatically fired file saving. New behavior takes care about current opened file, and if file is
dirtythen fire file saving.Besides this another change provide filtering file modification event. The main point is that when document has changed via UI editor automatically saves it and server may send event to the another clients that file has been modified, including the one's from which modifications where made.
What issues does this PR fix or reference?
#4076
Changelog
Trigger file saving operation on editor closing only when file has changes
Release Notes
Trigger file saving operation on editor closing only when file has changes
Docs PR
NA