All stack icons should have the 'viewBox' property #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise they don't render properly on the Dashboard. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
TylerJewell
approved these changes
Feb 21, 2017
|
Can one of the admins verify this patch? |
|
Well, duh :) Thanks Kaloyan. OK to merge. |
TylerJewell
added
the
kind/bug
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Otherwise they don't render properly on the Dashboard. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the rendering of the Zend and C++ stack icons on the Dashboard by adding the 'viewBox' property to the SVG files.
Before:
After:
Note that some 'advanced' stacks are enabled in the 'general' scope so their icons are visible.
What issues does this PR fix or reference?
None.
Changelog
Fixed rendering of some stack icons on the Dashboard.
Release Notes
Docs PR
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com