CHE-3583: Add new line to message area in Git commit window when Enter pressed #4280

vinokurig · 2017-03-01T15:09:06Z

What does this PR do?

Add possibility to insert new lines to 'message' text area in Git commit window

What issues does this PR fix or reference?

#3583

Changelog

Added possibility to insert new lines to 'message' text area in Git commit window by pressing ENTER key

Release Notes

Added possibility to insert new lines to 'message' text area in Git commit window by pressing ENTER key:

Docs PR

N/A Git commit window doesn't mentioned in docs

…r pressed

vzhukovs · 2017-03-01T16:20:33Z

-1 for realization.

It would be better to extend existed com.google.gwt.user.client.ui.TextArea and generalize behavior in widget's constructor. Smth like this:

public class NewTextArea extends TextArea {
    public NewTextArea() {
        super();

         new KeyboardNavigationHandler(this) {
            @Override
            public void onEnter(NativeEvent evt) {
                super.onEnter(evt);

                int cursorPos = getCursorPos();
                setText(new StringBuilder(getText()).insert(cursorPos, '\n').toString());
                setCursorPos(cursorPos + 2);
            }
        };
    }
}

then annotate

    @UiField(provided = true)
    TextArea message;

and create a new instance of message in constructor:

    ...
    @Inject
    protected CommitViewImpl(GitResources res, GitLocalizationConstant locale) {
        ...
        message = new NewTextArea();
    ...

The main pros from this approach is to reuse text area which handles enter key in other components.

codenvy-ci · 2017-03-01T19:34:40Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2078/

…en Enter pressed

vinokurig · 2017-03-02T14:35:25Z

@vzhukovskii Thanks for your advice, done.

codenvy-ci · 2017-03-02T15:23:43Z

Build finished.
Build success. $BUILD_URL

codenvy-ci · 2017-03-02T15:23:45Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2087/

vzhukovs · 2017-03-03T08:39:38Z

ide/che-core-ide-ui/src/main/java/org/eclipse/che/ide/ui/TextArea.java

+ *
+ * @author Igor Vinokur
+ */
+public class TextArea extends com.google.gwt.user.client.ui.TextArea {


Don't use same name in class hierarchy. Maybe it would be better to rename this class smth to related with multiline. e.g. MultilineTextArea or LFTextArea (from https://en.wikipedia.org/wiki/Newline)

Renamed to ShiftableTextArea WDYT?

…en Enter pressed

codenvy-ci · 2017-03-03T15:13:33Z

Build finished.
Build success. $BUILD_URL

codenvy-ci · 2017-03-03T15:13:33Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2097/

vparfonov · 2017-03-07T09:16:49Z

ide/che-core-ide-ui/src/main/java/org/eclipse/che/ide/ui/ShiftableTextArea.java

+    public ShiftableTextArea() {
+        super();
+
+        new KeyboardNavigationHandler(this) {


Can you move this code from constructor?
This looks weird and too complicated for reading

…3833)

codenvy-ci · 2017-03-07T16:28:34Z

Build finished.
Build # 2126 - FAILED

Please check console output at $BUILD_URL to view the results.

codenvy-ci · 2017-03-07T16:28:39Z

Build # 2126 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2126/ to view the results.

vinokurig · 2017-03-09T12:34:27Z

Selenium tests result:

[TEST]
[TEST] RESULTS ANALYSE:
[TEST]
[TEST] Command line: ./webdriver.sh --analyse 247
[TEST]
[TEST] CI results https://ci.codenvycorp.com/view/qa/job/che-integration-tests/247/
[TEST] 	- Failed:	81
[TEST]
[TEST] Local results:
[TEST] 	- Run:		0
[TEST] 	- Failed:	15
[TEST] 	com.codenvy.ide.codeserver.CheckMainFeatureForLanguageTest.checkLaunchingCodeserver
[TEST] 	com.codenvy.ide.dashboard.CreateAndDeleteProjectsTest.createAndDeleteProjectTest
[TEST] 	com.codenvy.ide.filewatcher.RefactoringFeatureTest.checkRefactorFilesFromIde
[TEST] 	com.codenvy.ide.filewatcher.RemoveFilesWithActiveTabs.checkDeletionWithMultiOpenedTabFromIde
[TEST] 	com.codenvy.ide.filewatcher.RemoveFilesWithActiveTabs.checkDeletionWithSingleOpenedTabFromIde
[TEST] 	com.codenvy.ide.filewatcher.RemoveFilesWithActiveTabs.checkRemovingWithoutIde
[TEST] 	com.codenvy.ide.filewatcher.UpdateFilesWithoutIDE.checkEditingFileWithoutIDE
[TEST] 	com.codenvy.ide.gwt.CheckSdmModeGwtFeatureTest.checkLaunchingCodeserver
[TEST] 	com.codenvy.ide.projectexplorer.CheckErrorMessageWhenCreationDuplicateFolderOrFileTest.checkDuplicatedFolder
[TEST] 	com.codenvy.ide.projectexplorer.CheckOnValidAndInvalidClassNameTest.shouldNotCreateClassWithInvalidNameInJavaFolder
[TEST] 	com.codenvy.ide.projectexplorer.CheckOnValidAndInvalidClassNameTest.shouldNotCreateClassWithInvalidNameInRootPackage
[TEST] 	com.codenvy.ide.projectexplorer.CheckOnValidAndInvalidPackageNameTest.createInvalidPackageNameInJavaFolderTest
[TEST] 	com.codenvy.ide.projectexplorer.CheckOnValidAndInvalidPackageNameTest.createInvalidPackageNameInRootPackageTest
[TEST] 	com.codenvy.ide.subversion.DiffViewTest.checkDiffView
[TEST] 	com.codenvy.ide.swagger.SwaggerTest.checkNameProjectTest
[TEST]
[TEST] Comparing with https://ci.codenvycorp.com/view/qa/job/che-integration-tests/247/ (not the latest results)
[TEST] If a test failed then it is NOT marked as regression.
[TEST]

Rerun failed tests result:

[TEST]
[TEST] RESULTS ANALYSE:
[TEST]
[TEST] Command line: ./webdriver.sh --analyse 247
[TEST]
[TEST] CI results https://ci.codenvycorp.com/view/qa/job/che-integration-tests/247/
[TEST] 	- Failed:	81
[TEST]
[TEST] Local results:
[TEST] 	- Run:		34
[TEST] 	- Failed:	0
[TEST]
[TEST] Comparing with https://ci.codenvycorp.com/view/qa/job/che-integration-tests/247/ (not the latest results)
[TEST] If a test failed then it is NOT marked as regression.
[TEST]
[TEST] NO REGRESSION, great job!
[TEST]

…r pressed (eclipse-che#4280)

Igor Vinokur added 2 commits March 1, 2017 15:59

CHE-3583: Add new line to message area in Git commit window when Ente…

e17850c

…r pressed

Merge branch 'master' of github.com:eclipse/che into CHE-3583

cf2d4a6

vinokurig added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 1, 2017

vinokurig requested review from vparfonov and JamesDrummond March 1, 2017 15:09

JamesDrummond approved these changes Mar 1, 2017

View reviewed changes

Igor Vinokur added 2 commits March 2, 2017 16:18

Merge branch 'master' of github.com:eclipse/che into CHE-3583

ca36b6c

fixup! CHE-3583: Add new line to message area in Git commit window wh…

d1b1609

…en Enter pressed

vinokurig requested a review from vzhukovs March 2, 2017 14:35

vzhukovs reviewed Mar 3, 2017

View reviewed changes

fixup! CHE-3583: Add new line to message area in Git commit window wh…

f327340

…en Enter pressed

vzhukovs approved these changes Mar 3, 2017

View reviewed changes

Merge branch 'master' of github.com:eclipse/che into CHE-3583

45f0eda

vparfonov reviewed Mar 7, 2017

View reviewed changes

Igor Vinokur added 2 commits March 7, 2017 15:41

Merge branch 'master' of github.com:eclipse/che into CHE-3583

8f87d79

fixup! CHE-3760: Fix git commit not staged specified path with amend (#…

db2c788

…3833)

vparfonov approved these changes Mar 9, 2017

View reviewed changes

vinokurig merged commit 7c68278 into master Mar 10, 2017

vinokurig deleted the CHE-3583 branch March 10, 2017 09:01

vinokurig added this to the 5.5.0 milestone Mar 10, 2017

JamesDrummond mentioned this pull request Mar 17, 2017

5.5.0 Milestone Overview #4358

Closed

9 tasks

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017

CHE-3583: Add new line to message area in Git commit window when Ente…

43d3607

…r pressed (eclipse-che#4280)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CHE-3583: Add new line to message area in Git commit window when Enter pressed #4280

CHE-3583: Add new line to message area in Git commit window when Enter pressed #4280

vinokurig commented Mar 1, 2017

vzhukovs commented Mar 1, 2017 •

edited

Loading

codenvy-ci commented Mar 1, 2017

vinokurig commented Mar 2, 2017

codenvy-ci commented Mar 2, 2017

codenvy-ci commented Mar 2, 2017

vzhukovs Mar 3, 2017

vinokurig Mar 3, 2017

codenvy-ci commented Mar 3, 2017

codenvy-ci commented Mar 3, 2017

vparfonov Mar 7, 2017

vinokurig Mar 7, 2017

codenvy-ci commented Mar 7, 2017

codenvy-ci commented Mar 7, 2017

vinokurig commented Mar 9, 2017

CHE-3583: Add new line to message area in Git commit window when Enter pressed #4280

CHE-3583: Add new line to message area in Git commit window when Enter pressed #4280

Conversation

vinokurig commented Mar 1, 2017

What does this PR do?

What issues does this PR fix or reference?

Changelog

Release Notes

Docs PR

vzhukovs commented Mar 1, 2017 • edited Loading

codenvy-ci commented Mar 1, 2017

vinokurig commented Mar 2, 2017

codenvy-ci commented Mar 2, 2017

codenvy-ci commented Mar 2, 2017

vzhukovs Mar 3, 2017

Choose a reason for hiding this comment

vinokurig Mar 3, 2017

Choose a reason for hiding this comment

codenvy-ci commented Mar 3, 2017

codenvy-ci commented Mar 3, 2017

vparfonov Mar 7, 2017

Choose a reason for hiding this comment

vinokurig Mar 7, 2017

Choose a reason for hiding this comment

codenvy-ci commented Mar 7, 2017

codenvy-ci commented Mar 7, 2017

vinokurig commented Mar 9, 2017

vzhukovs commented Mar 1, 2017 •

edited

Loading