Trigger file saving operation on editor closing only when file has changes #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com>
vzhukovs
added
the
kind/bug
|
Selenium testing wasn't found any regression |
|
Build finished. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2158/ |
vparfonov
approved these changes
Mar 13, 2017
9 tasks
slemeur
added
kind/enhancement
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…anges (eclipse-che#4393) Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes proposal disable automatically file saving on editor closing.
The previous version doesn't care about whether file changed or not and automatically fired file saving. New behavior takes care about current opened file, and if file is dirty then fire file saving.
Signed-off-by: Vladyslav Zhukovskii vzhukovskii@codenvy.com
What issues does this PR fix or reference?
#4076
Changelog
Trigger file saving operation on editor closing only when file has changes
Release Notes
Trigger file saving operation on editor closing only when file has changes
Docs PR
N/A