Improvements for intelligent commands - Phase 2 #4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Zatsarynnyi <azatsarynnyy@codenvy.com>
…open previous command's editors
slemeur
added
the
kind/enhancement
|
@azatsarynnyy : Could you please add the proper changelog (you can have multiple lines) |
slemeur
approved these changes
Mar 29, 2017
vparfonov
reviewed
Mar 29, 2017
| if (hotKey != null) { | ||
| SpanElement spanElement = Elements.createSpanElement(); | ||
| spanElement.getStyle().setMarginLeft("5px"); | ||
| spanElement.getStyle().setColor("#aaaaaa"); |
There was a problem hiding this comment.
How it will be on white theme?
There was a problem hiding this comment.
White theme is not handled yet.
Will be part of that issue: #4590
There was a problem hiding this comment.
BTW it looks good on both themes
vparfonov
approved these changes
Mar 29, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2315/ |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Intelligent commands UX and UI improvements: Changed flow of new command goal creation Processes and Previews dropdown lists made fully clickable Command editor made fullwidth Command editors now are restorable as well as text editors Added shortcuts for the default "Run" and "Debug" commands: Alt+R and Alt+D respectively Added tooltip for process ID in commands toolbar
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR polishes intelligent commands UX and UI based on the various feedbacks received during the beta
What issues does this PR fix or reference?
#4442
Changelog
Intelligent commands UX and UI improvements:
Release Notes
N/A
Will be released with #4389
Docs PR
eclipse-che/che-docs#168