CHE-4595: move CheConnectionClosedInformer to the ide-app module #4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve not used classes Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
skabashnyuk
approved these changes
Apr 6, 2017
|
Build # 2403 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2403/ to view the results. |
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
|
Build # 2412 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2412/ to view the results. |
|
Guys - no changelog. Every issue requires a changelog for tracking. TLs
are accepting hcanges and merging without completing the details. These
rules have been clear for a couple months now.
Tyler Jewell // CEO // tyler@codenvy.com // 978.884.5355
…On Fri, Apr 7, 2017 at 4:59 AM, Vitalii Parfonov ***@***.***> wrote:
Merged #4726 <#4726>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4726 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAX9CrftXyVONwtkesIYaY9QiXJOdZirks5rtiUtgaJpZM4M1g1U>
.
|
bmicklea
added
the
kind/task
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…ipse-che#4726) * CHE-4595 move CheConnectionClosedInformer to the ide-app module. Remove not used classes Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Parfonov vparfonov@codenvy.com
What does this PR do?
Move CheConnectionClosedInformer to the ide-app module. Remove not used classes
What issues does this PR fix or reference?
#4595
Changelog
Move CheConnectionClosedInformer to the ide-app module
Release Notes
N/A