Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-4593: Use JSON RPC for the debugger functionality #4739

Merged
merged 4 commits into from
Apr 7, 2017
Merged

Conversation

svor
Copy link
Contributor

@svor svor commented Apr 7, 2017

What does this PR do?

Adds JSON RPC connection via websocket between debugger server and IDE client and replaces previous message bus based IDE client services to JSON RPC based

What issues does this PR fix or reference?

#4593

Changelog

Replaced IDE client message bus based services to JSON RPC based for the debugger functionality

Release Notes

Docs PR

@svor svor added this to the 5.8.0 milestone Apr 7, 2017
@svor svor self-assigned this Apr 7, 2017
@svor svor requested review from dkuleshov and vparfonov April 7, 2017 11:39
ResultConfiguratorFromOne resultConfiguratorFromOne = mock(ResultConfiguratorFromOne.class);
OperationConfiguratorOneToNone operationConfiguratorOneToNone = mock(OperationConfiguratorOneToNone.class);

doReturn(methodNameConfigurator).when(configurator).newConfiguration();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate line

@svor svor merged commit 3280700 into master Apr 7, 2017
@svor svor deleted the CHE-4593 branch April 7, 2017 13:55
@codenvy-ci
Copy link

@bmicklea bmicklea added kind/enhancement A feature request - must adhere to the feature request template. kind/task Internal things, technical debt, and to-do tasks to be performed. and removed kind/enhancement A feature request - must adhere to the feature request template. labels Apr 11, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants