-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unification of JSON RPC codebase #5005
Conversation
Build # 2544 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2544/ to view the results. |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2548/ |
11db683
to
f5dff5f
Compare
Build # 2558 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2558/ to view the results. |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2559/ |
* Serializes JSON RPC request object into a string | ||
* | ||
* @param request | ||
* response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix typo
* <li>{@link OneToManyHandler}- to receive a request with a single parameter and multiple results </li> | ||
* <li>{@link ManyToNoneHandler} - to receive a notification with multiple parameters</li> | ||
* <li>{@link ManyToOneHandler} - to receive request with multiple parameters and a single result</li> | ||
* <li>{@link ManyToManyHandler} - to receive request with multiple parameters and mu</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sentence is not finished, I suppose: "...and multiple results"
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2569/ |
Build # 2580 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2580/ to view the results. |
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
77d59ed
to
f1fe41c
Compare
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
@@ -8,12 +8,12 @@ | |||
* Contributors: | |||
* Codenvy, S.A. - initial API and implementation | |||
*******************************************************************************/ | |||
package org.eclipse.che.api.core.jsonrpc; | |||
package org.eclipse.che.api.core.jsonrpc.commons; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javadoc
* <li>{@link ManyToManyHandler} - to receive request with multiple parameters and multiple results</li> | ||
* </ul> | ||
*/ | ||
@Singleton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think about if this class is thread safe
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Build # 2595 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2595/ to view the results. |
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2602/ |
What does this PR do?
We had two different implementations of JSON RPC subsystem because of different Java version used on client and server side. After we updated java version on client we no more need different implementations. This PR is intended to make code base as unified as possible for both sides. More accurately current difference is mostly within JSON parsing libraries (which are different for client and server sides).
What issues does this PR fix or reference?
#4616
Changelog
Client side (IDE) and server side (workspace agent, workspace master) JSON RPC services codebase is unified
Release Notes
Client side (IDE) and server side (workspace agent, workspace master) JSON RPC services codebase is unified