CHE-4803: fix items bulk selection and filtration. #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurinnoy
added
the
kind/bug
akurinnoy
changed the title
ashumilova
approved these changes
May 16, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2598/ |
olexii4
approved these changes
May 16, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2611/ |
benoitf
reviewed
May 18, 2017
| * @param id {string} a string to identify helper. | ||
| */ | ||
| removeHelper(id: string): void { | ||
| if (this.helpers.has(id)) { |
There was a problem hiding this comment.
do we need to check if map has the element, AFAIK delete will return either true or false but it can accept any element
There was a problem hiding this comment.
you're right, I'll remove this check.
benoitf
approved these changes
May 18, 2017
added 11 commits
May 18, 2017 17:03
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
- add possibility to bind callback which fires on search value change. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
- use CheListSvc for selection and filtration Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
- tests for selection and filtration for list items. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
|
Build # 2629 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2629/ to view the results. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* CHE-4803: modify che-list-header directive - add possibility to bind callback which fires on search value change. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: add protractor tests for list-workspaces component - tests for selection and filtration for list items. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * change timeout for updating model of workspace name Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in workspace-details-projects component Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in list-workspaces component - use CheListSvc for selection and filtration Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: add helper for filtration and selection items. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in list-factories component Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in list-stacks component Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * code clean-up Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in docker-registry-list component Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * fix test Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* CHE-4803: modify che-list-header directive - add possibility to bind callback which fires on search value change. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: add protractor tests for list-workspaces component - tests for selection and filtration for list items. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * change timeout for updating model of workspace name Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in workspace-details-projects component Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in list-workspaces component - use CheListSvc for selection and filtration Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: add helper for filtration and selection items. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in list-factories component Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in list-stacks component Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * code clean-up Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * CHE-4803: update list in docker-registry-list component Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * fix test Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the helper class which provides selection and filtration of items in a list.
There were fixed all lists where items can be simultaneously selected and filtered.
What issues does this PR fix or reference?
#4803
Changelog
[UD] Fixed bug when bulk operations work wrong after items are filtered.
Release Notes
N/A - bugfix
Docs PR
N/A - bugfix