CHE-5333. Mark editor state as dirty after undo/redo operations #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <rnikitenko@redhat.com>
RomanNikitenko
added
status/code-review
azatsarynnyy
approved these changes
Jun 20, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2854/ |
dkuleshov
approved these changes
Jun 20, 2017
vparfonov
approved these changes
Jun 22, 2017
|
Where are :
|
RomanNikitenko
added
the
kind/bug
|
@slemeur I've set label and milestone - thank you! |
|
@slemeur What you want review here? |
|
It is ok now. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have incorrect dirty state for editor at undo/redo operations and it leads to some bugs related to unsaved data.
So we need to track these operations and set a corresponding dirty state for editor.
What issues does this PR fix or reference?
#5333
Changelog
Mark editor state as dirty after undo/redo operations
Release Notes
Mark editor state as dirty after undo/redo operations
Docs PR
Don't need. It's a bug fix.
Signed-off-by: Roman Nikitenko rnikitenko@redhat.com