CHE-5477: Save button in Workspace config tab appears only after adding second symbol to config #5566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
second symbol to config Signed-off-by: Dmitrii Bocharov <dbocharo@redhat.com>
|
Looks like i don't have access to add labels. It's really strange that i can't do it for my own PR. Labels (as well as Reviewers, Assignees and the rest on the right column) are uneditable. |
ghost
requested a review
from 
ghost
added
the
status/code-review
ashumilova
approved these changes
Jul 10, 2017
ashumilova
added
the
kind/bug
benoitf
removed
the
status/code-review
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the corresponding issue - the save button in the workspace config tab appears only after adding second symbol to config
What issues does this PR fix or reference?
#5477
Changelog
Changed workspace is passed into the
updateWorkspaceConfigImportmethod and must be used further inswitchEditModeto detect the presence of changes instead ofthis.workspaceDetails.config.