Handle no-content response in DefaultHttpJsonRequest #5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
tolusha
approved these changes
Jul 10, 2017
voievodin
approved these changes
Jul 10, 2017
sleshchenko
approved these changes
Jul 10, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3026/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This request fixes DefaultHttpJsonRequest class not to check Content Type of response if it has status code 204 "No Content".
It allows, for example, to avoid unexpected IOException "No content" in case of successful DELETE request with empty response.
Signed-off-by: Dmytro Nochevnov dnochevnov@codenvy.com
@evoevodin, @tolusha: please, review this request.