Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project service: Lazy init of Tika #6179

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Project service: Lazy init of Tika #6179

merged 1 commit into from
Sep 11, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Sep 7, 2017

What does this PR do?

Lazy init of Tika.
Instead of initializing when constructor is called, initialize it at first call.

What issues does this PR fix or reference?

#6169

Changelog

lazily init the tika instance

Release Notes

N/A

Docs PR

N/A

Change-Id: I06872806f8a4c334614e1e15a12b5c533f5d8c11
Signed-off-by: Florent BENOIT fbenoit@redhat.com

@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/osio labels Sep 7, 2017
@benoitf benoitf self-assigned this Sep 7, 2017
Change-Id: I06872806f8a4c334614e1e15a12b5c533f5d8c11
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
@codenvy-ci
Copy link

@skabashnyuk
Copy link
Contributor

Can we do some sort of provider or so? Or hide initialization logic inside some class instead of doing it in REST service?

@benoitf
Copy link
Contributor Author

benoitf commented Sep 8, 2017

@skabashnyuk I fixed the issue, what you're asking is a refactoring on how ProjectService was designed ? AFAIK these changes are handled by maintainers not by contributors.

@garagatyi
Copy link

@benoitf Can you elaborate on why the kind label is set to bug?

@benoitf
Copy link
Contributor Author

benoitf commented Sep 8, 2017

@garagatyi you think it's an enhancement ?
For me it's a bug as creating an instance of an object should be always fast.

@garagatyi
Copy link

I do believe that marking everything as a bug is not convenient since it tempts ppl to mark everything as a bug to put up the priority and attention of other ppl in the project

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Sep 8, 2017
@benoitf
Copy link
Contributor Author

benoitf commented Sep 8, 2017

I've updated the label to enhancement if it's more convenient for people.

@garagatyi
Copy link

thanks

@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 11, 2017
@benoitf benoitf added this to the 5.18.0 milestone Sep 11, 2017
@benoitf benoitf merged commit e493f57 into master Sep 11, 2017
@benoitf benoitf deleted the lazy-init-tika branch September 11, 2017 08:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants