IDEX-3260 Remove factory API from Eclipse Che #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Icb28fc5a14c55a7c335bf4446373de33d67a9e2f Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
|
Why do you want to remove factory API from Che? |
|
So answer about removal it's because it's not aligned with Che vs OnPrem vs SaaS definition of the products It was added silently (no JIRA issue) |
|
Is it Tyler idea? |
|
yes |
|
so is it ok to merge ? |
|
It's ok from technical side, but I can't say GO to you to merge this PR. Please ask @skabashnyuk or @gazarenkov about that. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Icb28fc5a14c55a7c335bf4446373de33d67a9e2f
Signed-off-by: Florent BENOIT fbenoit@codenvy.com