Disable scheduling of methods annotated with @ScheduleRate/@ScheduleDelay if period/delay is negative #6505
Conversation
|
+1 |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3896/ |
sunix
force-pushed
the
disable-scheduled-period
branch
from
8ed8fee
to
60fd4b1
Compare
sunix
changed the title
| @@ -42,6 +42,9 @@ | |||
| /** @return - name of configuration parameter for initialDelay */ | |||
| String initialDelayParameterName() default ""; | |||
|
|
|||
| /** @return - name of configuration parameter for delay */ | |||
| /** | |||
| * @return - name of configuration parameter for delay. A negative delay value will disable the | |||
There was a problem hiding this comment.
it is rather non-positive than negative
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3904/ |
There was a problem hiding this comment.
Please sync with @slemeur to check if we need some docs or release notes changes.
|
Couple of words here https://github.com/eclipse/che/blob/master/core/commons/che-core-commons-schedule/README.md would be nice too. |
sunix
force-pushed
the
disable-scheduled-period
branch
from
60fd4b1
to
98bc59e
Compare
…elay if period/delay is not positive Signed-off-by: Sun Tan <sutan@redhat.com>
sunix
force-pushed
the
disable-scheduled-period
branch
from
98bc59e
to
db25d0f
Compare
|
@skabashnyuk @garagatyi I've updated the PR with your feedback |
|
Don't want to be PITA by saying it so late but have you considered using just zero instead of non-positive value? A single value for disabling feature is easier for understanding than a range. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3925/ |
|
@garagatyi I think a single value would confuse people. |
|
OK |
benoitf
added
the
kind/enhancement
What does this PR do?
Disable scheduling of methods annotated with @ScheduleRate/@ScheduleDelay if period/delay is negative
Thanks to this PR, we can fix #6383 by setting
che.docker.cleanup_period_min=-1