Send subscribe message when ws agent started #6634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <evidolob@codenvy.com>
tsmaeder
approved these changes
Oct 9, 2017
| import com.google.inject.Provider; | ||
| import com.google.inject.Singleton; | ||
| import com.google.web.bindery.event.shared.EventBus; | ||
| import javax.inject.Inject; |
There was a problem hiding this comment.
What's the policy around javax.inject vs. com.google.inject?
There was a problem hiding this comment.
javax.inject is more preferable than com.google.inject
benoitf
added
status/code-review
dkuleshov
approved these changes
Oct 9, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4057/ |
benoitf
removed
the
status/code-review
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send subscribe message when ws agent started
What issues does this PR fix or reference?
#6624
Release Notes
N/A