Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: fixed validation for recipe authoring widget. #6720

Merged
merged 2 commits into from
Oct 13, 2017
Merged

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

It fixes validation for recipe authoring widget.

What issues does this PR fix or reference?

fixes #5824

Release Notes

N/A - bugfix

Docs PR

N/A - bugfix

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 13, 2017
@akurinnoy akurinnoy self-assigned this Oct 13, 2017
comment: '# commented line'
}, {
instruction: 'FROM',
argument: 'codenvy/ubuntu_jdk8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use "eclipse/ubuntu_jdk8" (I know it's only a test)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections, I will replace all these strings

@ashumilova ashumilova added this to the 5.19.0 milestone Oct 13, 2017
@akurinnoy akurinnoy merged commit fcd3321 into master Oct 13, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 13, 2017
@codenvy-ci
Copy link

@akurinnoy akurinnoy deleted the CHE-5824 branch October 18, 2017 06:55
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
* CHE-5824: fix validation for recipe authoring widget.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! CHE-5824: fix validation for recipe authoring widget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation does not work in the "Build stack from recipe" form
5 participants