Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Che 756: make the loading view fit the height of the screen to avoid scrolling #739

Merged
merged 2 commits into from
Mar 31, 2016
Merged

Che 756: make the loading view fit the height of the screen to avoid scrolling #739

merged 2 commits into from
Mar 31, 2016

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Mar 18, 2016 •
edited by benoitf
Loading

_1 Upvote_

@ashumilova
Copy link
Contributor

ok

@olexii4
Copy link
Contributor

olexii4 commented Mar 18, 2016

+1

ashumilova
ashumilova reviewed Mar 21, 2016
View reviewed changes
dashboard/src/components/widget/loader/che-loader-crane.directive.js

setCraneSize();

// re-init all animations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove if not needed

@akurinnoy akurinnoy force-pushed the CHE-756 branch 2 times, most recently from 919eedf to df51210 Compare March 24, 2016 07:45
ashumilova
ashumilova reviewed Mar 24, 2016
View reviewed changes
dashboard/src/app/ide/ide-loader/ide-loader.html
@@ -1,16 +1,19 @@
<div class="ide-loader" layout="column" layout-align="center center">
<che-loader layout="column" layout-align="center center">
<!--crane and terminals-->
<div class="che-loader-animation-panel main-page" layout="row">
<div flex="initial" flex-gt-sm="60">
<div class="che-loader-animation-panel main-page" layout="row" flex="">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex="" can be just flex

@ashumilova
Copy link
Contributor

please, give a look at these notifications:

ERROR in ./src/components/widget/loader/che-loader-crane.directive.js

/home/Ann/codenvy/che/dashboard/src/components/widget/loader/che-loader-crane.directive.js
96:13 error You should use the angular.isFunction method angular/typecheck-function
108:74 error "event" is defined but never used no-unused-vars
118:10 error Redundant double negation in an if statement condition no-extra-boolean-cast
133:36 error "jQuery" is not defined no-undef
141:27 error "jQuery" is not defined no-undef
150:27 error "jQuery" is not defined no-undef

✖ 6 problems (6 errors, 0 warnings)

@ashumilova
Copy link
Contributor

resizing the crane seems ok

@akurinnoy
Copy link
Contributor Author

fixed

@ashumilova
Copy link
Contributor

squash 1st and last commit and merge please

Oleksii Kurinnyi added 2 commits March 31, 2016 09:37
CHE-756: make the loading view fit the height of the screen to avoid …
a355dfb 
…scrolling

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
remove unused CSS styles
4f0d873
@akurinnoy akurinnoy merged commit ccf6b6c into master Mar 31, 2016
@akurinnoy akurinnoy deleted the CHE-756 branch April 5, 2016 07:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akurinnoy @ashumilova @olexii4 @benoitf