Selenium: change the way to click the plus panel button in the Consoles page object #8024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Consoles selenium page object
SkorikSergey
added
kind/task
tolusha
reviewed
Dec 22, 2017
| @@ -160,7 +160,8 @@ public void clickOnServerItemInContextMenu() { | |||
| } | |||
|
|
|||
| public void clickOnPlusMenuButton() { | |||
| redrawDriverWait.until(visibilityOf(plusMenuBtn)).click(); | |||
| redrawDriverWait.until(visibilityOf(plusMenuBtn)); | |||
| new Actions(seleniumWebDriver).moveToElement(plusMenuBtn).click().perform(); | |||
…thod of Console page object
tolusha
approved these changes
Dec 22, 2017
dmytro-ndp
approved these changes
Dec 22, 2017
| @@ -56,7 +56,7 @@ | |||
| /** @author Skoryk Serhii */ | |||
| public class WorkspaceDetailsSingleMachineTest { | |||
| private static final String PROJECT_NAME = NameGenerator.generate("project", 4); | |||
| private static final Map<String, Boolean> EXPECTED_INSTALLERS = | |||
| private static final ImmutableMap<String, Boolean> EXPECTED_INSTALLERS = | |||
There was a problem hiding this comment.
Could you, please, fix EXPECTED_VARIABLES constant in the same way?
benoitf
removed
the
status/code-review
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have unexpected fail of WorkspaceDetailsSingleMachineTest selenium test. The context menu for adding new Terminal or opening the Servers list is not appeared after clicking button.
Log:
Report with reproduced bug:
https://ci.codenvycorp.com/view/qa/job/che-integration-tests-master-docker/122/Selenium_tests_report/
Screenshot:
What issues does this PR fix or reference?
#8020