Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: prevent to start and open in IDE a workspace with unsupported recipe type #8260

Merged
merged 9 commits into from
Jan 17, 2018

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

For a workspace with unsupported recipe type,
in navbar:

  • prevents to open a workspace in IDE, opens Workspace Details page instead;

on Workspace Details page:

  • prevents to start a workspace, open it in IDE or update its config;
  • displays "Not supported" instead of current status;

screenshot-localhost-3000-2018-01-11-16-50-29-920

What issues does this PR fix or reference?

#8139

Release Notes

Docs PR

@akurinnoy akurinnoy added the status/in-progress This issue has been taken by an engineer and is under active development. label Jan 11, 2018
@akurinnoy akurinnoy self-assigned this Jan 11, 2018
@akurinnoy
Copy link
Contributor Author

ci-test

@benoitf benoitf added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jan 11, 2018
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8260
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Added new status - 'Not supported'

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
On Workspace Details page the user is prohibited to start a workspace or
update its configuration if this workspace is built on a recipe of
an unsupported type.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
The left mouse click in navbar on a recent workspace based on
unsupported recipe type opens Workspace Details page instead of the IDE.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Some stacks with an unsupported recipe types are removed from quickstart
list on Create Workspace page.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8260
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@akurinnoy
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8260
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@akurinnoy akurinnoy changed the title [WIP] Dashboard: prevent to start and open in IDE a workspace with unsupported recipe type Dashboard: prevent to start and open in IDE a workspace with unsupported recipe type Jan 16, 2018
@ashumilova ashumilova added this to the 6.0.0-M5 milestone Jan 17, 2018
@akurinnoy akurinnoy removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jan 17, 2018
@akurinnoy akurinnoy merged commit 5ee0dbc into eclipse-che:master Jan 17, 2018
@akurinnoy akurinnoy deleted the CHE-8139 branch August 23, 2018 10:21
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
…ted recipe type (#8260)

* code clean-up

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* rework che-button directive, add unit tests for che-button-default

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* add ability to disable workspace-status-button, add unit test

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* rework workspace-status-directive

Added new status - 'Not supported'

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* prevent start and update workspace based on unsupported recipe type

On Workspace Details page the user is prohibited to start a workspace or
update its configuration if this workspace is built on a recipe of
an unsupported type.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* prevent to open unsupported workspace from navbar

The left mouse click in navbar on a recent workspace based on
unsupported recipe type opens Workspace Details page instead of the IDE.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* eliminate unsupported stacks from quickstart list

Some stacks with an unsupported recipe types are removed from quickstart
list on Create Workspace page.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* update license

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! rework che-button directive, add unit tests for che-button-default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants