che-8250: fix github redirect url, when no port is defined #8275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna Shumilova ashumilo@redhat.com
What does this PR do?
There is the difference between the port detection in native JavaScript and angular for the following format of the URL:
http://example.com/#/some/path
var port = $location.port(); // => 80
var port = location.port; // => empty string
so in this case the redirect URL used to have "80" port appended which is correct, but did not pass validation in keycloak, cause defined URLs have the following format:
What issues does this PR fix or reference?
#8250
Release Notes
N/A
Docs PR
N/A