Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

che-8250: fix github redirect url, when no port is defined #8275

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

ashumilova
Copy link
Contributor

Signed-off-by: Anna Shumilova ashumilo@redhat.com

What does this PR do?

There is the difference between the port detection in native JavaScript and angular for the following format of the URL:

http://example.com/#/some/path

var port = $location.port(); // => 80
var port = location.port; // => empty string
so in this case the redirect URL used to have "80" port appended which is correct, but did not pass validation in keycloak, cause defined URLs have the following format:
screenshot from 2018-01-12 14-15-08

What issues does this PR fix or reference?

#8250

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
@ashumilova ashumilova added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 12, 2018
@ashumilova ashumilova added this to the 6.0.0-M5 milestone Jan 12, 2018
@ashumilova ashumilova self-assigned this Jan 12, 2018
@ashumilova ashumilova merged commit e7e7606 into master Jan 15, 2018
@ashumilova ashumilova deleted the che-8250 branch January 15, 2018 07:56
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 15, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants