Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added kubernetes infrastructure #8559

Merged
merged 11 commits into from
Feb 8, 2018
Merged

Added kubernetes infrastructure #8559

merged 11 commits into from
Feb 8, 2018

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Feb 1, 2018 •
edited
Loading

What does this PR do?

Adds Kubernetes implementation of infrastructure.
So Kubernetes infrastructure supports dockerimage and kubernetes recipes.

OpenShift infrastructure is reworked to extend k8s infra and it supports dockerimage, kubernetes and openshift recipes.

Initial work was contributed by @sapguyd. So, thanks to him for that.

What issues does this PR fix or reference?

#5908

Release Notes

Implemented Kubernetes infrastructure.

Docs PR

Will be provided later

@sleshchenko sleshchenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 1, 2018
@sleshchenko sleshchenko self-assigned this Feb 1, 2018
riuvshin
riuvshin reviewed Feb 1, 2018
View reviewed changes
dockerfiles/init/manifests/che.env Outdated
##### Openshift Infrastructure #####
##### #####
#

Copy link
Contributor

@riuvshin riuvshin Feb 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing for openshift?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenShift will reuse k8s infra configuration properties. I'll doc it.
OpenShift section will have only OpenShift specific properties like che.infra.openshift.project

riuvshin
riuvshin reviewed Feb 1, 2018
View reviewed changes
dockerfiles/init/modules/k8s/files/scripts/k8s.yml Outdated
app: che
name: che
data:
CHE_HOST: "192.168.99.100.nip.io"
Copy link
Contributor

@riuvshin riuvshin Feb 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have any plans to get rid of these hardcodes?
192.168.99.100 is a minikube VM ip on your localhost right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is minikube IP on my machine.

  1. For the time we don't have other installations to test this stuff
  2. I didn't want to use shell script to deploy Che on k8s since it doesn't seem right to me, so we probably need to wait for helm deployment instructions which would allow us to customize this, I hope

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if you have a suggestion how to customize this properly with acceptable defaults and without shell script your help would be very appreciated.

@sleshchenko sleshchenko force-pushed the k8s-infra branch 4 times, most recently from 04b5024 to f44b810 Compare February 2, 2018 14:09
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. labels Feb 5, 2018
@sleshchenko
Copy link
Member Author

ci-test-ocp

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8559
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@riuvshin
Copy link
Contributor

riuvshin commented Feb 5, 2018

ci-test-ocp

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8559
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@sleshchenko sleshchenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Feb 6, 2018
@sleshchenko sleshchenko removed the kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. label Feb 6, 2018
@sleshchenko sleshchenko force-pushed the k8s-infra branch 3 times, most recently from 1495296 to 758bb34 Compare February 7, 2018 08:23
@sleshchenko sleshchenko force-pushed the k8s-infra branch 2 times, most recently from 3497b86 to 20c8808 Compare February 7, 2018 14:00
@sleshchenko
Copy link
Member Author

ci-test-ocp

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8559
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988 Ohrimenko1988 reopened this Feb 8, 2018
@Ohrimenko1988
Copy link
Contributor

QE team has checked and approved test report

guydc and others added 11 commits February 8, 2018 10:08
@guydc @sleshchenko
CHE-5908 Begin k8s infra poc
50c2bd5 
Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc @sleshchenko
CHE-5908 Change Server Exposure, Resolving, Project & Infra to suppor…
7e571b6 
…t ingress-based routes

Signed-off-by: Guy Daich <guy.daich@sap.com>
@sleshchenko
CHE-5908 Add Kubernetes infrastructure
242f56a
@sleshchenko
CHE-5908: add config to deploy Che on k8s
9f350af 
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@sleshchenko
CHE-5908 Add an ability to configure security context for pods
ac1c516
@sleshchenko
CHE-5908 Allow to customize ingress controller specific annotations f…
cb43481 
…or ingresses

Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@sleshchenko
CHE-8611 Add warning suppressing when namespace/project doesn't exist…
d5707e2 
… on removing
@sleshchenko
CHE-5908 Add CHE_INFRA_KUBERNETES_NAMESPACE into yml file
4ee894e
@sleshchenko
CHE-5908 Add aliases for kubernetes configuration properties
0256ff1
@sleshchenko
CHE-5908 Add warning when ingress annotations are absent in configura…
9c88f33 
…tion
@sleshchenko
CHE-5908 Update ingress annotations for Nginx 0.9.0
10ac41f
@sleshchenko sleshchenko merged commit 7053fab into eclipse-che:master Feb 8, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 8, 2018
@benoitf benoitf added this to the 6.1.0 milestone Feb 8, 2018
@sleshchenko sleshchenko deleted the k8s-infra branch February 8, 2018 09:22
This was referenced Feb 8, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riuvshin riuvshin riuvshin left review comments

@akorneta akorneta akorneta approved these changes

@garagatyi garagatyi garagatyi approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@benoitf benoitf benoitf approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@sleshchenko sleshchenko

Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
9 participants
@sleshchenko @codenvy-ci @riuvshin @Ohrimenko1988 @benoitf @skabashnyuk @garagatyi @akorneta @guydc