Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Delete the 'loader.waitOnClosed()' from the page object 'Preferences' #8576

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Selenium: Delete the 'loader.waitOnClosed()' from the page object 'Preferences' #8576

merged 1 commit into from
Feb 2, 2018

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Delete the 'loader.waitOnClosed()' from the page object 'Preferences'
  • Wait of closing loader is not needed in this place and can produce to failing of the selenium test

What issues does this PR fix or reference?

#8529

@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/production labels Feb 2, 2018
@artaleks9 artaleks9 merged commit 34a5806 into master Feb 2, 2018
@artaleks9 artaleks9 deleted the preferences branch February 2, 2018 14:23
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 5, 2018
@benoitf benoitf added this to the 6.1.0 milestone Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@artaleks9 @SkorikSergey @Ohrimenko1988 @benoitf